Moodle
  1. Moodle
  2. MDL-30532

qeupgradehelper preupgrade quiz list bad link

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      You need a site that has been upgraded from Moodle 2.0 with quiz attempts.

      Go to qeupgrade helper in the admin menu, and choose the 'List already upgrade quizzes that can be reset'

      Make sure the links to the quizzes in the table work.

      Show
      You need a site that has been upgraded from Moodle 2.0 with quiz attempts. Go to qeupgrade helper in the admin menu, and choose the 'List already upgrade quizzes that can be reset' Make sure the links to the quizzes in the table work.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      33244

      Description

      The qeupgradehelper preupgrade quiz list creates a bad link for linking to quizes. it links with an id=thequizes name.
      The attached patch fixes it.

      Version of qeupgradehelper: 9a40c191f616e2268881dbdb66b8bf429ac7d000

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Oops! thanks for submitting a fix.

          Show
          Tim Hunt added a comment - Oops! thanks for submitting a fix.
          Hide
          Adrian Greeve added a comment -

          The patch works. Thanks Trevor. I can provide a link to git hub for this fix if needed.

          Show
          Adrian Greeve added a comment - The patch works. Thanks Trevor. I can provide a link to git hub for this fix if needed.
          Hide
          Tim Hunt added a comment -

          I'm just kicking this back into Peer review state so that it shows up on my dashboard. I have been too busy to submit it for integration, but I hope to do it today.

          Show
          Tim Hunt added a comment - I'm just kicking this back into Peer review state so that it shows up on my dashboard. I have been too busy to submit it for integration, but I hope to do it today.
          Hide
          Tim Hunt added a comment -

          Trevor and Adrian, thanks for your help.

          Show
          Tim Hunt added a comment - Trevor and Adrian, thanks for your help.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Tim - integrated now

          Show
          Sam Hemelryk added a comment - Thanks Tim - integrated now
          Hide
          Michael de Raadt added a comment -

          Test result: passed. No worries.

          Show
          Michael de Raadt added a comment - Test result: passed. No worries.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: