Moodle
  1. Moodle
  2. MDL-30539

No blog RSS icon visible (Backport MDL-30386 to 2.0 and 2.1)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.0.6, 2.1.3
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Blog
    • Labels:
    • Testing Instructions:
      1. Log in as a student and browse to a user's blog.
      2. Check that an orange RSS button is displayed on the page and that it links to the RSS feed for the blog.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      33253

      Description

      No blog RSS icon visible

        Issue Links

          Activity

          Hide
          Jason Fowler added a comment -

          Hey Sam, you peer reviewed the original issue, could you please have a look at this one too - the code is identical to the original ...

          Show
          Jason Fowler added a comment - Hey Sam, you peer reviewed the original issue, could you please have a look at this one too - the code is identical to the original ...
          Hide
          Sam Hemelryk added a comment -

          Linking to original issue MDL-30386

          Show
          Sam Hemelryk added a comment - Linking to original issue MDL-30386
          Hide
          Sam Hemelryk added a comment -

          Hi Jason,

          I've just had a look at this now.
          There is one more thing to do, I see Apu made an additional commit on MDL-30386 as the has_capability call had been made previously and its result stored in a variable. Essentially Apu was saving one DB call, this should also be backported if possible.

          To find it:

          git log --grep='MDL-30386' master
          

          Look for the commit Apu made and cherry-pick that onto your branch.
          Once done feel free to put it up for integration (gets my +1)

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Jason, I've just had a look at this now. There is one more thing to do, I see Apu made an additional commit on MDL-30386 as the has_capability call had been made previously and its result stored in a variable. Essentially Apu was saving one DB call, this should also be backported if possible. To find it: git log --grep='MDL-30386' master Look for the commit Apu made and cherry-pick that onto your branch. Once done feel free to put it up for integration (gets my +1) Cheers Sam
          Hide
          Jason Fowler added a comment -

          Thanks Sam, I'll get that sorted straight away

          Show
          Jason Fowler added a comment - Thanks Sam, I'll get that sorted straight away
          Hide
          Jason Fowler added a comment -

          Those changes have been made Sam, submitting for integration now

          Show
          Jason Fowler added a comment - Those changes have been made Sam, submitting for integration now
          Hide
          Aparup Banerjee added a comment -

          Thanks Jason,
          I've integrated that into 21 and 20 (as you've provided the patch and seen that it works too).

          this is up for testing now.

          Show
          Aparup Banerjee added a comment - Thanks Jason, I've integrated that into 21 and 20 (as you've provided the patch and seen that it works too). this is up for testing now.
          Hide
          Adrian Greeve added a comment - - edited

          I created a blog with two students. Access to the blog was to everyone. I also made sure that rss was enabled on the site.

          I couldn't see an rss feed link anywhere regardless of whether I was an admin or a student.

          Clicking on a blog will result in this notice: Notice: Trying to get property of non-object in /var/www/repositories/intergration/MOODLE_21_STABLE/moodle/blog/rsslib.php on line 60

          I did notice that if you go to make an entry in your own blog that the Blog RSS Feed link is displayed in the navigation bar. This will let you subscribe to your own blog.
          Tested with moodle version 2.1

          Show
          Adrian Greeve added a comment - - edited I created a blog with two students. Access to the blog was to everyone. I also made sure that rss was enabled on the site. I couldn't see an rss feed link anywhere regardless of whether I was an admin or a student. Clicking on a blog will result in this notice: Notice: Trying to get property of non-object in /var/www/repositories/intergration/MOODLE_21_STABLE/moodle/blog/rsslib.php on line 60 I did notice that if you go to make an entry in your own blog that the Blog RSS Feed link is displayed in the navigation bar. This will let you subscribe to your own blog. Tested with moodle version 2.1
          Hide
          Jason Fowler added a comment -

          Sorry, poor instructions, the blog was to be a user's blog, viewed from the profile of "Student B" by "Student A"

          Show
          Jason Fowler added a comment - Sorry, poor instructions, the blog was to be a user's blog, viewed from the profile of "Student B" by "Student A"
          Hide
          Aparup Banerjee added a comment -

          pushing thru for testing again

          Show
          Aparup Banerjee added a comment - pushing thru for testing again
          Hide
          Adrian Greeve added a comment -

          As per the new instructions of switching on rss in the options, checking the blog of someone else in the same course (Must navigate to the participants of the course), viewing their profile and then clicking blogs. You will see the blog rss link.
          Test passed.
          Thanks

          Show
          Adrian Greeve added a comment - As per the new instructions of switching on rss in the options, checking the blog of someone else in the same course (Must navigate to the participants of the course), viewing their profile and then clicking blogs. You will see the blog rss link. Test passed. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: