Remember page number

I'll throw some code out here just to get things started: https://github.com/mackensen/moodle/compare/master...MDL-3054. I admit that I don't know the appropriate way to bump a version number.

I think this makes sense as default quiz behaviour; should it be teacher-configurable?

Proof of concept is easy (although I note that you have added one extra DB query to every page-view of attempt.php, so not that easy to get right). What is needed is a complete solution that dots all the is and crosses all the ts.

• I would always start new attempts from page 1 (or is it 0), so don't do that change in startattempt.php
• In the DB definition, I would put the currentpage column next to layout.
• You don't yet have any code to go to the current page when the attempt is resumed.

@Tim thanks for responding. New attempts start at page 0 and this code doesn't change that. The line in startattempt.php does resume attempts from where the user left off (at least when I tested it). I'll take another look at attempt.php and try to make that more efficient.

Ah, I was misreading that change in startattempt.php. However, you are assuming that students always get to attempt.php from startattempt.php. This is not try. Try searching the code for "->attempt_url(" and "attempt.php".

Amended and updated. The only other point of entry I see for a student is review.php, and I would think with a review the student would want to start at the beginning of the quiz.

I will try to look tomorrow, but not promises.

I think we are getting there, but more review comments:

1. In mod/quiz/attempt.php, better to use set_field than update_record.

2. In startattempt.php, I think a page= in the URL should override the one stored in the DB, so change the default for optional_param to -1, and then only do your new line of code if $page is -1 (which will be the most common case).

3. I just fixed a bug that altered mod/quiz/version.php, so once this weekly is out, you will have to rebase and fix merge conflicts.

Rebased, merged and amended, with the suggested fixes.

One final thing:

if ($attemptobj->get_currentpage() !== $page) {

I think that should be !=

Makes sense to me. Amended.

Thanks for sticking with it Charles. Submitting for integration now.

Thanks guys, this has been integrated into master after a quick whitespace cleanup.

Plz, amend this ASAP!

Number of errors: 1
Column currentpage of table quiz_attempts difference found in unsigned: false !== true

aka, install says signed, upgrade says unsigned!

Ciao

gr, I've got this https://github.com/nebgor/moodle/compare/integration-master...MDL-3054 , git://github.com/nebgor/moodle.git branch MDL-3054

I'm assuming that $currentpage isn't negative ever (from perusing the code) but i may be wrong Tim.

tester: we may have to revert this if not fixed.

No need to revert, I will fix it today.

We really need to get rid of the whole unsigned thing completely.

Apu, +1 for your fix. Thanks.

Apu's commit has been integrated, and CI DB checks are happy now, so this can be normally tested. Thanks!

Works nicely

This is now available in the git and cvs repositories.

Consider the responsibility of your fingerprints engraved there for future generations!

Thanks for the work, closing, ciao

Bless all for work on this. Know it is off the beaten path that social constructionist want to take

Documented in 2.3 here http://docs.moodle.org/23/en/Using_Quiz so removing docs label.