Moodle
  1. Moodle
  2. MDL-30544

the "temporarily disable notifications" checkbox causes your preferences to be removed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Messages
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      Go to your messaging preferences (my profile settings > Messaging)

      Make sure that "temporarily disable notifications" is not checked. Make a note of your messaging preferences. Turn them all off but one (or something) to make it easier to remember. Save.

      Tick "temporarily disable notifications". Save.

      Untick "temporarily disable notifications". Your messaging preferences should have been preserved.

      Show
      Go to your messaging preferences (my profile settings > Messaging) Make sure that "temporarily disable notifications" is not checked. Make a note of your messaging preferences. Turn them all off but one (or something) to make it easier to remember. Save. Tick "temporarily disable notifications". Save. Untick "temporarily disable notifications". Your messaging preferences should have been preserved.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-30544_disable_notifications
    • Rank:
      33258

      Description

      turn on Temporarily disable notifications, save, turn off "Temporarily disable notifications" and your notification preferences are gone

      Introduced by MDL-22232

        Activity

        Hide
        Andrew Davis added a comment -

        Ive added branches. The only code change Ive made is adding an if around the block that alters notification preferences.

        Show
        Andrew Davis added a comment - Ive added branches. The only code change Ive made is adding an if around the block that alters notification preferences.
        Hide
        Aparup Banerjee added a comment -

        this change looks good to me

        Show
        Aparup Banerjee added a comment - this change looks good to me
        Hide
        Aparup Banerjee added a comment -

        gogogo

        Show
        Aparup Banerjee added a comment - gogogo
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Ankit Agarwal added a comment -

        all good and working!
        Thanks

        Show
        Ankit Agarwal added a comment - all good and working! Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay!

        Closing and big thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Sent upstream! Just in time for Moodle 2.2rc1 (if related), yay! Closing and big thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: