Moodle
  1. Moodle
  2. MDL-28351 add more support fro user->suspended META
  3. MDL-30548

Show the user status of "Suspended" in the front-end of the application.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.0.6
    • Fix Version/s: 2.2.1
    • Component/s: Administration
    • Labels:
      None
    • Rank:
      33262

      Description

      In general, we prefer to suspend Moodle users, rather than permanently delete them. We do this by setting mdl_user.Suspended=1.

      It would be very nice if we could spot suspended users from the front-end of the system.

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          To integrators: please cherry pick to 2.2.x, feel free to tweak the new lang strings...

          Show
          Petr Škoda added a comment - To integrators: please cherry pick to 2.2.x, feel free to tweak the new lang strings...
          Hide
          Petr Škoda added a comment -

          see the commit messages for more details

          Show
          Petr Škoda added a comment - see the commit messages for more details
          Hide
          Sam Hemelryk added a comment -

          Hi Petr,

          I'm sending this back at the moment, for sure this is 99% fine, but there are a couple of minor things I think should be fixed up before this goes in:

          1. The language strings need to be tidied up for sure:
            • admin.php: unsuspenduser === suspenduser
            • auth.php I think suspended_help should be something like: `Suspended user accounts cannot log in or user web services, and any outgoing messages are blocked.`
          2. admin/user.php when printing a user row in the table it would be VERY useful if there were a user-suspended CSS class or such so that different styles can be applied to suspended users. I think it would also be good to get rid of all of those dimmed and dimmed_text classes and add a single CSS rule to style suspended users as we want.
          3. Looking at how profile.php and view.php are using the hiddendetails cap, wouldn't it be better to make suspended a hidden field and then deal with it in the same way we do all other hidden fields?

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Petr, I'm sending this back at the moment, for sure this is 99% fine, but there are a couple of minor things I think should be fixed up before this goes in: The language strings need to be tidied up for sure: admin.php: unsuspenduser === suspenduser auth.php I think suspended_help should be something like: `Suspended user accounts cannot log in or user web services, and any outgoing messages are blocked.` admin/user.php when printing a user row in the table it would be VERY useful if there were a user-suspended CSS class or such so that different styles can be applied to suspended users. I think it would also be good to get rid of all of those dimmed and dimmed_text classes and add a single CSS rule to style suspended users as we want. Looking at how profile.php and view.php are using the hiddendetails cap, wouldn't it be better to make suspended a hidden field and then deal with it in the same way we do all other hidden fields? Cheers Sam
          Hide
          Petr Škoda added a comment -

          Thanks for the valuable feedback!

          I will add csv upload support too.

          Show
          Petr Škoda added a comment - Thanks for the valuable feedback! I will add csv upload support too.
          Hide
          Petr Škoda added a comment -

          I have fixed the issues mentioned above and added support for suspended flag in user filtering subsystem. Thanks!

          Show
          Petr Škoda added a comment - I have fixed the issues mentioned above and added support for suspended flag in user filtering subsystem. Thanks!
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now.

          A couple of things about the integration:

          1. I have to fix a couple of conflicts in the settings file as my lang_string changes have been integrated now and I converted the new get_string calls there..
          2. I noted the crazy abomination that is dimming text at the moment in the base there... I'll be researching and opening a new issue for that shortly.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now. A couple of things about the integration: I have to fix a couple of conflicts in the settings file as my lang_string changes have been integrated now and I converted the new get_string calls there.. I noted the crazy abomination that is dimming text at the moment in the base there... I'll be researching and opening a new issue for that shortly. Cheers Sam
          Hide
          Petr Škoda added a comment -

          thanks!

          Show
          Petr Škoda added a comment - thanks!
          Hide
          Ankit Agarwal added a comment -

          This is working great!
          Thanks

          Show
          Ankit Agarwal added a comment - This is working great! Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao
          Hide
          Helen Foster added a comment -

          suspended string typo reported as MDL-31419.

          Show
          Helen Foster added a comment - suspended string typo reported as MDL-31419 .
          Hide
          Andrea Bicciolo added a comment - - edited

          Reopening as there is still a front end where knowing the status of a suspended users my be really useful. When manually enrolling users, in the popup window where users can be searched and enrolled with a given role, no information is present about the status of the account. That holds true also when using the alternative enrollment interface available when accessing the manual users enroll clicking the "Enroll users" icon available in course's "Enrollment methods" page.

          Possible solutions:

          • show the suspended status close to the name (to be checked if that may be impacted by the "hiddenuserfields" admin setting)
          • allow filtering users in manual enrollment screens (could be something like "exclude suspended accounts")
          Show
          Andrea Bicciolo added a comment - - edited Reopening as there is still a front end where knowing the status of a suspended users my be really useful. When manually enrolling users, in the popup window where users can be searched and enrolled with a given role, no information is present about the status of the account. That holds true also when using the alternative enrollment interface available when accessing the manual users enroll clicking the "Enroll users" icon available in course's "Enrollment methods" page. Possible solutions: show the suspended status close to the name (to be checked if that may be impacted by the "hiddenuserfields" admin setting) allow filtering users in manual enrollment screens (could be something like "exclude suspended accounts")
          Hide
          Petr Škoda added a comment -

          PLEASE, DO NOT REOPEN ISSUES THAT WENT THROUGH INTEGRATION!

          Show
          Petr Škoda added a comment - PLEASE, DO NOT REOPEN ISSUES THAT WENT THROUGH INTEGRATION!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: