Moodle

Invalid get_string() identifier: 'selectcategoryabove' or component 'question'

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.3, 2.2, 2.3
  • Fix Version/s: 2.1.4, 2.2.1
  • Component/s: Questions, Quiz
  • Labels:
    None
  • Testing Instructions:
    Hide

    It is really hard to trigger this message. I think you need to create a role that has question:view capabilities, but none of the other question capabilities, then go to the question bank. It is meant to display a message saying 'Select a category above'.

    Alternatively, just review the patch, and see that it solves the missing string problem.

    Show
    It is really hard to trigger this message. I think you need to create a role that has question:view capabilities, but none of the other question capabilities, then go to the question bank. It is meant to display a message saying 'Select a category above'. Alternatively, just review the patch, and see that it solves the missing string problem.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Aparup Banerjee added a comment -

Hi Tim,
As we're moving strings around here, i suspect/feel we may need AMOS scripts in the commit ?

Show
Aparup Banerjee added a comment - Hi Tim, As we're moving strings around here, i suspect/feel we may need AMOS scripts in the commit ?
Hide
Permalink
Tim Hunt added a comment -

You mean like the AMOS script that is already there?

Show
Tim Hunt added a comment - You mean like the AMOS script that is already there?
Hide
Permalink
Aparup Banerjee added a comment - - edited

lol, thanks, that'll teach me NOT to look at commit summaries thinking they are the message.

This has been integrated into 2.1.x, 2.2.x and master.

Show
Aparup Banerjee added a comment - - edited lol, thanks, that'll teach me NOT to look at commit summaries thinking they are the message. This has been integrated into 2.1.x, 2.2.x and master.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks for fixing this, Tim
Works Fine.

FYI:
print_choose_category_message is not used in quiz. Probably, it will be nice to remove it from mod/quiz/editlib.php

Show
Rajesh Taneja added a comment - Thanks for fixing this, Tim Works Fine. FYI: print_choose_category_message is not used in quiz. Probably, it will be nice to remove it from mod/quiz/editlib.php
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yes, you did it!

Now your code is part of the best weeklies released ever, many thanks!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Yes, you did it! Now your code is part of the best weeklies released ever, many thanks! Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: