Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30558

Invalid get_string() identifier: 'selectcategoryabove' or component 'question'

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Questions, Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      It is really hard to trigger this message. I think you need to create a role that has question:view capabilities, but none of the other question capabilities, then go to the question bank. It is meant to display a message saying 'Select a category above'.

      Alternatively, just review the patch, and see that it solves the missing string problem.

      Show
      It is really hard to trigger this message. I think you need to create a role that has question:view capabilities, but none of the other question capabilities, then go to the question bank. It is meant to display a message saying 'Select a category above'. Alternatively, just review the patch, and see that it solves the missing string problem.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Gliffy Diagrams

        Attachments

          Activity

          Hide
          nebgor Aparup Banerjee added a comment -

          Hi Tim,
          As we're moving strings around here, i suspect/feel we may need AMOS scripts in the commit ?

          Show
          nebgor Aparup Banerjee added a comment - Hi Tim, As we're moving strings around here, i suspect/feel we may need AMOS scripts in the commit ?
          Hide
          timhunt Tim Hunt added a comment -

          You mean like the AMOS script that is already there?

          Show
          timhunt Tim Hunt added a comment - You mean like the AMOS script that is already there?
          Hide
          nebgor Aparup Banerjee added a comment - - edited

          lol, thanks, that'll teach me NOT to look at commit summaries thinking they are the message.

          This has been integrated into 2.1.x, 2.2.x and master.

          Show
          nebgor Aparup Banerjee added a comment - - edited lol, thanks, that'll teach me NOT to look at commit summaries thinking they are the message. This has been integrated into 2.1.x, 2.2.x and master.
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Thanks for fixing this, Tim
          Works Fine.

          FYI:
          print_choose_category_message is not used in quiz. Probably, it will be nice to remove it from mod/quiz/editlib.php

          Show
          rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this, Tim Works Fine. FYI: print_choose_category_message is not used in quiz. Probably, it will be nice to remove it from mod/quiz/editlib.php
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Yes, you did it!

          Now your code is part of the best weeklies released ever, many thanks!

          Closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you did it! Now your code is part of the best weeklies released ever, many thanks! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12