Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide
      1. Create one block (html for example) at course level.
      2. Set it to be shown in any page.
      3. TEST: The block is show in the course page and also in any of the activity pages of the course.
      4. Go to any activity (say, one forum) and edit the block there.
      5. TEST: The "display on pagetypes" setting shows "any page"
      6. Change that setting to "any forum module page" and save changes
      7. TEST: The block is displayed in the forum pages.
      8. TEST: The block is displayed in other forum activities.
      9. TEST: The block is NOT displayed in other activitites.
      10. TEST: The block is NOT displayed in course page.
      11. Go to any forum and edit the block
      12. TEST: the "display on pagetypes" shows "any forum module page" (as you picked some points above).
      13. TEST: There is one "any page" available the last in the list.
      14. Select that "any page" option and save the settings.
      15. TEST: The block is visible in the forum where you have edited it.
      16. TEST: The block is visible in any activity of the course.
      17. TEST: The block is visible in the course page, and can be edited there, with the "display on pagetypes" showing "any page".
      Show
      Create one block (html for example) at course level. Set it to be shown in any page. TEST: The block is show in the course page and also in any of the activity pages of the course. Go to any activity (say, one forum) and edit the block there. TEST: The "display on pagetypes" setting shows "any page" Change that setting to "any forum module page" and save changes TEST: The block is displayed in the forum pages. TEST: The block is displayed in other forum activities. TEST: The block is NOT displayed in other activitites. TEST: The block is NOT displayed in course page. Go to any forum and edit the block TEST: the "display on pagetypes" shows "any forum module page" (as you picked some points above). TEST: There is one "any page" available the last in the list. Select that "any page" option and save the settings. TEST: The block is visible in the forum where you have edited it. TEST: The block is visible in any activity of the course. TEST: The block is visible in the course page, and can be edited there, with the "display on pagetypes" showing "any page".
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30340.subcontext_locks
    • Rank:
      33346

      Description

      This was detected when researching about MDL-30340

      For "sticky" blocks at any context (those being shown in child contexts), it's possible to lead to one "locked" status where one block cannot be sent back to its original context anymore.

      The ultimate cause for this is that, both in 21_STABLE and master, the "*" option, previously always available @ child contexts was kept out, and that option is the one that enabled the block to go back, and be shown, where it was defined originally.

      So this patch simply ensures that, if the block is being edited 'at distance' (aka, in one of the subcontexts it's show) the '*' option will be always available, to efectively revert it to its original status and prevent locked situations.

      That is, ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Sending to integration. Note the branch names use the original issue number because it was researched and fixed there, but that doesn't matter much really.

          INTEGRATORS: Note this should be backported to 21_STABLE too.

          INTEGRATORS: This must be integrated BEFORE both MDL-30566 and MDL-30340

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Sending to integration. Note the branch names use the original issue number because it was researched and fixed there, but that doesn't matter much really. INTEGRATORS: Note this should be backported to 21_STABLE too. INTEGRATORS: This must be integrated BEFORE both MDL-30566 and MDL-30340
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master only). New issue for back-porting will be created @ MDL-30340.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master only). New issue for back-porting will be created @ MDL-30340 .
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing as far as MDL-30340 has been passed.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing as far as MDL-30340 has been passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this is now part of the new, just created 22_STABLE and v2.2.0 release, yay! Thanks!

          Closing

          Show
          Eloy Lafuente (stronk7) added a comment - And this is now part of the new, just created 22_STABLE and v2.2.0 release, yay! Thanks! Closing

            People

            • Assignee:
              Eloy Lafuente (stronk7)
              Reporter:
              Eloy Lafuente (stronk7)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Martin Dougiamas
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: