Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.2
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide
      1. Create one block (html for example) at course level.
      2. Set it to be shown in any page.
      3. TEST: The block is show in the course page and also in any of the activity pages of the course.
      4. Go to any activity (say, one forum) and edit the block there.
      5. TEST: The "display on pagetypes" setting shows "any page"
      6. Change that setting to "any forum module page" and save changes
      7. TEST: The block is displayed in the forum pages.
      8. TEST: The block is displayed in other forum activities.
      9. TEST: The block is NOT displayed in other activitites.
      10. TEST: The block is NOT displayed in course page.
      11. Go to any forum and edit the block
      12. TEST: the "display on pagetypes" shows "any forum module page" (as you picked some points above).
      13. TEST: There is one "any page" available the last in the list.
      14. Select that "any page" option and save the settings.
      15. TEST: The block is visible in the forum where you have edited it.
      16. TEST: The block is visible in any activity of the course.
      17. TEST: The block is visible in the course page, and can be edited there, with the "display on pagetypes" showing "any page".
      Show
      Create one block (html for example) at course level. Set it to be shown in any page. TEST: The block is show in the course page and also in any of the activity pages of the course. Go to any activity (say, one forum) and edit the block there. TEST: The "display on pagetypes" setting shows "any page" Change that setting to "any forum module page" and save changes TEST: The block is displayed in the forum pages. TEST: The block is displayed in other forum activities. TEST: The block is NOT displayed in other activitites. TEST: The block is NOT displayed in course page. Go to any forum and edit the block TEST: the "display on pagetypes" shows "any forum module page" (as you picked some points above). TEST: There is one "any page" available the last in the list. Select that "any page" option and save the settings. TEST: The block is visible in the forum where you have edited it. TEST: The block is visible in any activity of the course. TEST: The block is visible in the course page, and can be edited there, with the "display on pagetypes" showing "any page".
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30340.subcontext_locks
    • Rank:
      33346

      Description

      This was detected when researching about MDL-30340

      For "sticky" blocks at any context (those being shown in child contexts), it's possible to lead to one "locked" status where one block cannot be sent back to its original context anymore.

      The ultimate cause for this is that, both in 21_STABLE and master, the "*" option, previously always available @ child contexts was kept out, and that option is the one that enabled the block to go back, and be shown, where it was defined originally.

      So this patch simply ensures that, if the block is being edited 'at distance' (aka, in one of the subcontexts it's show) the '*' option will be always available, to efectively revert it to its original status and prevent locked situations.

      That is, ciao

        Issue Links

          Activity

          Eloy Lafuente (stronk7) created issue -
          Eloy Lafuente (stronk7) made changes -
          Field Original Value New Value
          Fix Version/s STABLE backlog [ 10463 ]
          Eloy Lafuente (stronk7) made changes -
          Priority Minor [ 4 ] Blocker [ 1 ]
          Assignee moodle.com [ moodle.com ] Eloy Lafuente (stronk7) [ stronk7 ]
          Eloy Lafuente (stronk7) made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/stronk7/moodle/compare/master...MDL-30340.subcontext_locks
          Pull Master Branch MDL-30340.subcontext_locks
          Pull from Repository git://github.com/stronk7/moodle.git
          Testing Instructions # Create one block (html for example) at course level.
          # Set it to be shown in any page.
          # TEST: The block is show in the course page and also in any of the activity pages of the course.
          # Go to any activity (say, one forum) and edit the block there.
          # TEST: The "display on pagetypes" setting shows "any page"
          # Change that setting to "any forum module page" and save changes
          # TEST: The block is displayed in the forum pages.
          # TEST: The block is displayed in other forum activities.
          # TEST: The block is NOT displayed in other activitites.
          # TEST: The block is NOT displayed in course page.
          # Go to any forum and edit the block
          # TEST: the "display on pagetypes" shows "any forum module page" (as you picked some points above).
          # TEST: There is one "any page" available the last in the list.
          # Select that "any page" option and save the settings.
          # TEST: The block is visible in the forum where you have edited it.
          # TEST: The block is visible in any activity of the course.
          # TEST: The block is visible in the course page, and can be edited there, with the "display on pagetypes" showing "any page".
          Eloy Lafuente (stronk7) made changes -
          Link This issue is a clone of MDL-30566 [ MDL-30566 ]
          Michael de Raadt made changes -
          Labels triaged
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.2 [ 10656 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester dougiamas
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 05/Dec/11

            People

            • Assignee:
              Eloy Lafuente (stronk7)
              Reporter:
              Eloy Lafuente (stronk7)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Martin Dougiamas
              Participants:
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: