Moodle
  1. Moodle
  2. MDL-30569

Editing the front page when defaulthomepage = mymoodle causes bad redirect

    Details

    • Testing Instructions:
      Hide
      1. Login as admin and Goto site admin>appearance>navigation
      2. Set defaulthomepage to my moodle
      3. Go to front page and press the turn editing on button
      4. Turn the editing to off
      5. make sure you stay in front page and editing is toggled properly
      Show
      Login as admin and Goto site admin>appearance>navigation Set defaulthomepage to my moodle Go to front page and press the turn editing on button Turn the editing to off make sure you stay in front page and editing is toggled properly
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-30569-master
    • Rank:
      33351

      Issue Links

        Activity

        Hide
        Ray Lawrence added a comment -

        Which role does this behaviour occur for? Would this be correct for a Teacher on the front page but incorrect for and Admin (not a role of course) or Manager?

        Show
        Ray Lawrence added a comment - Which role does this behaviour occur for? Would this be correct for a Teacher on the front page but incorrect for and Admin (not a role of course) or Manager?
        Hide
        Dan Poltawski added a comment -

        This is for an admin. For a teacher I would expect they would not get the 'turn editing on' button on the site index (only when actually on their my moodle page).

        Show
        Dan Poltawski added a comment - This is for an admin. For a teacher I would expect they would not get the 'turn editing on' button on the site index (only when actually on their my moodle page).
        Hide
        Ray Lawrence added a comment -

        Agreed. I meant front page if the user is teacher on front page.

        I read (and re-read) the report, agree this is wrong otherwise. Odd thing is the old force my home (moodle) behaviour from 1.9 doesn't work any more so this an anomaly.

        Show
        Ray Lawrence added a comment - Agreed. I meant front page if the user is teacher on front page. I read (and re-read) the report, agree this is wrong otherwise. Odd thing is the old force my home (moodle) behaviour from 1.9 doesn't work any more so this an anomaly.
        Hide
        Dan Poltawski added a comment -

        Hi Michael,

        I don't think this is the same as the linked issue, and I have tested the patch in the linked issue and it doesn't fix this issue.

        Reopening.

        Show
        Dan Poltawski added a comment - Hi Michael, I don't think this is the same as the linked issue, and I have tested the patch in the linked issue and it doesn't fix this issue. Reopening.
        Hide
        Michael de Raadt added a comment -

        Hi, Dan.

        Sorry, they looked very similar to me, but on closer inspection, they are different.

        Show
        Michael de Raadt added a comment - Hi, Dan. Sorry, they looked very similar to me, but on closer inspection, they are different.
        Hide
        Michael de Raadt added a comment -

        I'm raising the priority on this bug as it has the potential to cause a large amount of grief.

        Show
        Michael de Raadt added a comment - I'm raising the priority on this bug as it has the potential to cause a large amount of grief.
        Hide
        Sam Hemelryk added a comment -

        Changes look good thanks guys. Please put up for integration when you are ready.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Changes look good thanks guys. Please put up for integration when you are ready. Cheers Sam
        Hide
        Ankit Agarwal added a comment -

        Thanks Sam for the review.
        Branches added.
        Up for integration
        Thanks

        Show
        Ankit Agarwal added a comment - Thanks Sam for the review. Branches added. Up for integration Thanks
        Hide
        Aparup Banerjee added a comment -

        Thanks, this has been integrated.

        (worked for me too on master but) now up for proper testing.

        Show
        Aparup Banerjee added a comment - Thanks, this has been integrated. (worked for me too on master but) now up for proper testing.
        Hide
        Jason Fowler added a comment -

        Works in 2.3dev, 2.2, and 2.1

        Show
        Jason Fowler added a comment - Works in 2.3dev, 2.2, and 2.1
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

        Now... disconnect, relax and enjoy the next days, yay!

        Closing...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: