Moodle
  1. Moodle
  2. MDL-30576

completionThreshold not saved in the database and minProgressMeasure should have a default value.

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.2
        • Fix Version/s: 2.2.1
        • Component/s: SCORM
        • Testing Instructions:
          Hide

          It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1.
          1. Download the DMI Test package.
          2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness
          3. Check the Log to make sure these errors don't appear:
          ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "".
          ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: ""
          (The minProgressMeasure value is not specified but completedByMeasure is specified as true - Activity 2, DMI).

          NOTE: Many other errors are reported by this test - this patch only addresses the issues mentioned.

          Show
          It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1. 1. Download the DMI Test package . 2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness 3. Check the Log to make sure these errors don't appear: ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "". ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: "" (The minProgressMeasure value is not specified but completedByMeasure is specified as true - Activity 2, DMI). NOTE: Many other errors are reported by this test - this patch only addresses the issues mentioned.
        • Affected Branches:
          MOODLE_22_STABLE
        • Fixed Branches:
          MOODLE_22_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          master_MDL-30576
        • Pull Master Diff URL:

          Description

          The completionThreshold value is not saved correctly in the database.
          While running the DMI SCORM 2004 Test package the following error is thrown up -
          ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "".

          Also,
          According to SCORM 2004 spec. the minPrgoressMeasure (threshold) should have "1.0" as default value.
          Some activities (like Activity 2 in DMI test package) depend on the default value without specifying it in the imsmanifest.xml file.
          ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: ""
          (The minProgressMeasure value is not specified but completedByMeasure is specified as true - Activity 2, DMI).

            Gliffy Diagrams

              Issue Links

              will help resolve

              Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-28805 ADL TEST: DMI

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Mayank Gupta added a comment -

                This patch -
                https://github.com/mayankgupta/moodle/commit/b5a26fe11a03e4c5debfbd702bb8d3e34c2abf10

                Fixes the mapping of ADLCP:COMPLETIONTHRESHOLD so that the threshold value is saved correctly in the database.
                After applying patch -
                Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "0.8"

                The patch also fixes the default value of minProgressMeasure to be saved in the database.
                This will fix errors like -
                ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: ""

                Thanks,
                Mayank Gupta.

                Show
                Mayank Gupta added a comment - This patch - https://github.com/mayankgupta/moodle/commit/b5a26fe11a03e4c5debfbd702bb8d3e34c2abf10 Fixes the mapping of ADLCP:COMPLETIONTHRESHOLD so that the threshold value is saved correctly in the database. After applying patch - Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "0.8" The patch also fixes the default value of minProgressMeasure to be saved in the database. This will fix errors like - ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: "" Thanks, Mayank Gupta.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                TIA and ciao

                Show
                Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                Hide
                Permalink
                Mayank Gupta added a comment -

                Thanks Eloy, I have updated the branch, should not cause any conflict issues now.

                Thanks,
                Mayank Gupta.

                Show
                Mayank Gupta added a comment - Thanks Eloy, I have updated the branch, should not cause any conflict issues now. Thanks, Mayank Gupta.
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Hi Mayank,

                Which branches does this need to be applied to, is it master only, or can it be backported to MOODLE_22_STABLE and others?
                Presently we are holding off integration of master only issues, however if it can be backported we can look at it immediately

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - Hi Mayank, Which branches does this need to be applied to, is it master only, or can it be backported to MOODLE_22_STABLE and others? Presently we are holding off integration of master only issues, however if it can be backported we can look at it immediately Cheers Sam
                Hide
                Permalink
                Dan Marsden added a comment -

                Hi Sam - this one can go in 22Stable and master - thanks.

                Show
                Dan Marsden added a comment - Hi Sam - this one can go in 22Stable and master - thanks.
                Hide
                Permalink
                Sam Hemelryk added a comment -

                Thanks Dan.. I've checked this out now, all was fine, and its now been integrated!

                Cheers
                Sam

                Show
                Sam Hemelryk added a comment - Thanks Dan.. I've checked this out now, all was fine, and its now been integrated! Cheers Sam
                Hide
                Permalink
                Adrian Greeve added a comment -

                After much head banging and frustration, I'm happy to say that this passed.

                Show
                Adrian Greeve added a comment - After much head banging and frustration, I'm happy to say that this passed.
                Hide
                Permalink
                Dan Marsden added a comment -

                yes... SCORM has the tendency to drive people mad....

                Show
                Dan Marsden added a comment - yes... SCORM has the tendency to drive people mad....
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

                Now... disconnect, relax and enjoy the next days, yay!

                Closing...ciao

                Show
                Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao
                Hide
                Permalink
                Mayank Gupta added a comment -

                @Adrian - It would'nt be this crazy once MDLSITE-1595 is resolved.

                Thanks Dan, Sam, Adrian, Eloy for reviewing, integrating, testing and closing this issue.

                Happy Holidays!

                -Mayank.

                Show
                Mayank Gupta added a comment - @Adrian - It would'nt be this crazy once MDLSITE-1595 is resolved. Thanks Dan, Sam, Adrian, Eloy for reviewing, integrating, testing and closing this issue. Happy Holidays! -Mayank.

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: