Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30576

completionThreshold not saved in the database and minProgressMeasure should have a default value.

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.2
    • 2.2.1
    • SCORM
    • MOODLE_22_STABLE
    • MOODLE_22_STABLE
    • master_MDL-30576
    • Hide

      It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1.
      1. Download the DMI Test package.
      2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness
      3. Check the Log to make sure these errors don't appear:
      ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "".
      ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: ""
      (The minProgressMeasure value is not specified but completedByMeasure is specified as true - Activity 2, DMI).

      NOTE: Many other errors are reported by this test - this patch only addresses the issues mentioned.

      Show
      It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1. 1. Download the DMI Test package . 2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness 3. Check the Log to make sure these errors don't appear: ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "". ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: "" (The minProgressMeasure value is not specified but completedByMeasure is specified as true - Activity 2, DMI). NOTE: Many other errors are reported by this test - this patch only addresses the issues mentioned.

    Description

      The completionThreshold value is not saved correctly in the database.
      While running the DMI SCORM 2004 Test package the following error is thrown up -
      ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "0.8" - LMS Returned: "".

      Also,
      According to SCORM 2004 spec. the minPrgoressMeasure (threshold) should have "1.0" as default value.
      Some activities (like Activity 2 in DMI test package) depend on the default value without specifying it in the imsmanifest.xml file.
      ERROR: Evaluating GetValue("cmi.completion_threshold") - Expected: "1.0" - LMS Returned: ""
      (The minProgressMeasure value is not specified but completedByMeasure is specified as true - Activity 2, DMI).

      Attachments

        Issue Links

          will help resolve

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-28805 ADL TEST: DMI

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              danmarsden Dan Marsden
              mayank_gupta2005 Mayank Gupta
              Dan Marsden Dan Marsden
              Sam Hemelryk Sam Hemelryk
              Adrian Greeve Adrian Greeve
              Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jan/12