Moodle
  1. Moodle
  2. MDL-30577

cmi.credit and cmi.mode are not evaluated correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.1
    • Component/s: SCORM
    • Testing Instructions:
      Hide

      It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1.
      1. Download the DMI Test package.
      2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness
      3. Check the Log to make sure these errors no longer appear:

      ERROR: Evaluating GetValue("cmi.credit") - Expected: "credit" - LMS Returned: "no-credit" (x7)
      ERROR: Evaluating GetValue("cmi.mode") - Expected: "normal" - LMS Returned: "" (x9)

      NOTE: Many other errors are reported by this test - this patch only addresses the issues mentioned.

      Show
      It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1. 1. Download the DMI Test package . 2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness 3. Check the Log to make sure these errors no longer appear: ERROR: Evaluating GetValue("cmi.credit") - Expected: "credit" - LMS Returned: "no-credit" (x7) ERROR: Evaluating GetValue("cmi.mode") - Expected: "normal" - LMS Returned: "" (x9) NOTE: Many other errors are reported by this test - this patch only addresses the issues mentioned.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-30577
    • Rank:
      33359

      Description

      While running the SCORM 2004 conformance test for DMI test package the cmi.credit and cmi.mode elements are not evaluated correctly - 7 cmi.credit and 9 cmi.mode similar issues are thrown.

      ERROR: Evaluating GetValue("cmi.credit") - Expected: "credit" - LMS Returned: "no-credit" (x7)

      ERROR: Evaluating GetValue("cmi.mode") - Expected: "normal" - LMS Returned: "" (x9)

        Issue Links

          Activity

          Hide
          Mayank Gupta added a comment -

          Adding a fix for 7 cmi.credit and 9 cmi.mode similar issues with this patch -

          https://github.com/mayankgupta/moodle/commit/ab94be6bd104401cb29f1ec69f5438556b35a97d

          After applying the patch -

          Evaluating GetValue("cmi.credit") - Expected: "credit" - LMS Returned: "credit" (x7)

          Evaluating GetValue("cmi.mode") - Expected: "normal" - LMS Returned: "normal" (x9)

          Thanks,
          Mayank Gupta.

          Show
          Mayank Gupta added a comment - Adding a fix for 7 cmi.credit and 9 cmi.mode similar issues with this patch - https://github.com/mayankgupta/moodle/commit/ab94be6bd104401cb29f1ec69f5438556b35a97d After applying the patch - Evaluating GetValue("cmi.credit") - Expected: "credit" - LMS Returned: "credit" (x7) Evaluating GetValue("cmi.mode") - Expected: "normal" - LMS Returned: "normal" (x9) Thanks, Mayank Gupta.
          Hide
          Dan Marsden added a comment -

          NOTE TO INTEGRATOR: This patch is for Master only - relates to SCORM 2004 which we don't "officially" support...yet...

          We have plans to set up an easy way for people to see the results of the Test harness against qa.moodle.net without having to set it up themselves - the start of this is in MDLSITE-1595

          Show
          Dan Marsden added a comment - NOTE TO INTEGRATOR: This patch is for Master only - relates to SCORM 2004 which we don't "officially" support...yet... We have plans to set up an easy way for people to see the results of the Test harness against qa.moodle.net without having to set it up themselves - the start of this is in MDLSITE-1595
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Mayank Gupta added a comment -

          Thanks Eloy, I have updated the branch, should not cause any conflict issues now.

          Thanks,
          Mayank Gupta.

          Show
          Mayank Gupta added a comment - Thanks Eloy, I have updated the branch, should not cause any conflict issues now. Thanks, Mayank Gupta.
          Hide
          Aparup Banerjee added a comment -

          this is for 2.2+ and 2.3 as i've previously understood from Dan.

          Show
          Aparup Banerjee added a comment - this is for 2.2+ and 2.3 as i've previously understood from Dan.
          Hide
          Aparup Banerjee added a comment -

          Thanks , thats integrated.

          Show
          Aparup Banerjee added a comment - Thanks , thats integrated.
          Hide
          Rossiani Wijaya added a comment -

          Through jabber conversation, Dan mentioned this is in-working implementation and as long as the error log doesn't content any error message describe in testing instructions, then the patch is good.

          My error log doesn't display the error for cmi.mode and cmi.credit. Therefore the patch works great.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Through jabber conversation, Dan mentioned this is in-working implementation and as long as the error log doesn't content any error message describe in testing instructions, then the patch is good. My error log doesn't display the error for cmi.mode and cmi.credit. Therefore the patch works great. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao
          Hide
          Mayank Gupta added a comment -

          Thanks Dan, Aparup, Rossiani, Eloy for reviewing, integrating, testing and closing this issue.

          Happy Holidays!

          -Mayank.

          Show
          Mayank Gupta added a comment - Thanks Dan, Aparup, Rossiani, Eloy for reviewing, integrating, testing and closing this issue. Happy Holidays! -Mayank.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: