[MDL-30579] Data Model Elements are being initialized with an empty string - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2, 2.3
Fix Version/s: 2.2.1
Component/s: SCORM
Labels:
- SCORM_2004
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE
Pull from Repository:
git://github.com/mayankgupta/moodle.git
Pull Master Branch:
master_~~MDL-30579~~
Pull Master Diff URL:
https://github.com/mayankgupta/moodle/compare/master...master_MDL-30579
Testing Instructions:

Hide

It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1.
1. Download the DMI Test package.
2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness
3. Check the Log to make sure this error doesn't show:
Evaluating GetValue("cmi.scaled_passing_score") - Expected: "" - LMS Returned: ""
ERROR: Evaluating GetLastError("") - Expected: "403" - LMS Returned: "0"

NOTE: Many other errors are reported by this test package - this patch only addresses the issues mentioned.

Show
It can be tested by running the SCORM Test Harness for DMI package - Data Model Implementation Test 1. 1. Download the DMI Test package . 2. Run the SCORM Test Harness for DMI as specified here - SCORM Test Harness 3. Check the Log to make sure this error doesn't show: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "" - LMS Returned: "" ERROR: Evaluating GetLastError("") - Expected: "403" - LMS Returned: "0" NOTE: Many other errors are reported by this test package - this patch only addresses the issues mentioned.

Description

Data Model Elements are being initialized with an empty string. Thus, a 403 errorCode is not thrown (where it should be thrown).
The following illustrates the above -

Evaluating GetValue("cmi.scaled_passing_score") - Expected: "" - LMS Returned: ""
ERROR: Evaluating GetLastError("") - Expected: "403" - LMS Returned: "0"

403 error should have been thrown since, cmi.scaled_passing_score has not been initialized (Activity 1 - DMI Test package).

Attachments

Issue Links

will help resolve

MDL-28805 ADL TEST: DMI

Closed

Activity

People

Assignee:: Dan Marsden

Reporter:: Mayank Gupta

Peer reviewer:: Dan Marsden

Integrator:: Aparup Banerjee

Tester:: Rajesh Taneja

Participants:: Aparup Banerjee, Dan Marsden, Eloy Lafuente (stronk7), Mayank Gupta, Rajesh Taneja

Component watchers:: Dan Marsden, Matteo Scaramuccia, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 05/Dec/11 3:39 PM

Updated:: 13/Dec/11 2:36 AM

Resolved:: 10/Dec/11 8:16 AM

Fix Release Date:: 9/Jan/12