Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-3058

Some strings are built by concatenation...

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.7
    • Component/s: Lesson
    • Labels:
      None
    • Environment:
      All
    • Affected Branches:
      MOODLE_15_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE

      Description

      In the lesson module, there are some strings being built by concatenations of different strings. For example, this is used a lot of times:

      $data = format_string($lessonpages[$answer->jumpto]->title). .get_string(page, lesson);

      returning strings of the type:

      Initial Question page

      Although this is correct in English, there are a lot of languages where the order is absolutely incorrect and it should be:

      Page Initial Question (P?gina Pregunta Inicial, in Spanish, for example).

      So these type of construction must be changed to an unique get_string call, with the 'dynamic' part sent as parameter. This would allow translators to build the correct phrases in their language.

      Ciao

        Attachments

          Activity

            People

            Assignee:
            bushido Mark Nielsen
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              7/Nov/06