Moodle
  1. Moodle
  2. MDL-30583

Add a setting to prevent the navigation from adding front page activities to the navigation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.3
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin and run the upgrade
      2. Visit Settings > Appearance > Navigation and make sure navshowfrontpagemods is enabled
      3. Create several front page activities within the main menu and the front page topic section (has to be enabled)
      4. Browse to the site home page and make sure they are shown in the navigation.
      5. Browse to one of the activities and make sure the nav bar shows the correct thing.
      6. Visit Settings > Appearance > Navigation and disable navshowfrontpagemods
      7. Browse to the site home page and make sure they are NOT shown in the navigation.
      8. Browse to one of the activities and make sure the nav bar shows the correct thing and that now it is shown in the navigation.
      Show
      Log in as an admin and run the upgrade Visit Settings > Appearance > Navigation and make sure navshowfrontpagemods is enabled Create several front page activities within the main menu and the front page topic section (has to be enabled) Browse to the site home page and make sure they are shown in the navigation. Browse to one of the activities and make sure the nav bar shows the correct thing. Visit Settings > Appearance > Navigation and disable navshowfrontpagemods Browse to the site home page and make sure they are NOT shown in the navigation. Browse to one of the activities and make sure the nav bar shows the correct thing and that now it is shown in the navigation.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-30583-master
    • Rank:
      33365

      Description

      As required by moodle.org we don't want to display front page activities in the navigation.
      Presently we use a local plugin to tidy up the navigation as we require, however it would be great to have a setting to control this.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Putting this up for peer-review now.

          Show
          Sam Hemelryk added a comment - Putting this up for peer-review now.
          Hide
          Andrew Davis added a comment -

          The code looks good. Is the fix version on this issue set correctly?

          Show
          Andrew Davis added a comment - The code looks good. Is the fix version on this issue set correctly?
          Hide
          Sam Hemelryk added a comment -

          Thanks for looking at this Andrew, its up for integration now.
          Indeed fix version is correct, as this is a new feature it will only be included on the master branch and the next master release will be 2.3.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks for looking at this Andrew, its up for integration now. Indeed fix version is correct, as this is a new feature it will only be included on the master branch and the next master release will be 2.3. Cheers Sam
          Hide
          Aparup Banerjee added a comment -

          oops, stopping review - this is master only and we're not doing that for now.

          Show
          Aparup Banerjee added a comment - oops, stopping review - this is master only and we're not doing that for now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Uhm, sorry again but surely we should hold this until MDL-26155 is integrated and then use the new lang_string() artifact?

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Uhm, sorry again but surely we should hold this until MDL-26155 is integrated and then use the new lang_string() artifact? Ciao
          Hide
          Sam Hemelryk added a comment - - edited

          Hi Eloy,

          Hehe just to keep things fun I've created the following branch based off MDL-26155 so that this can still be reviewed/integrated today if you wish:

          Branch: wip-MDL-30583-m23-after-MDL-26155
          Diff url: https://github.com/samhemelryk/moodle/compare/wip-MDL-26155-m23...wip-MDL-30583-m23-after-MDL-26155
          Fetch cmd: git fetch git://github.com/samhemelryk/moodle.git wip-MDL-30583-m23-after-MDL-26155
          

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - - edited Hi Eloy, Hehe just to keep things fun I've created the following branch based off MDL-26155 so that this can still be reviewed/integrated today if you wish: Branch: wip-MDL-30583-m23-after-MDL-26155 Diff url: https://github.com/samhemelryk/moodle/compare/wip-MDL-26155-m23...wip-MDL-30583-m23-after-MDL-26155 Fetch cmd: git fetch git://github.com/samhemelryk/moodle.git wip-MDL-30583-m23-after-MDL-26155 Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Rebased and afterMDL-26155 branch removed. Please use the original branch again

          Show
          Sam Hemelryk added a comment - Rebased and after MDL-26155 branch removed. Please use the original branch again
          Hide
          Aparup Banerjee added a comment -

          This new setting is now integrated into master.

          ps: added comma to string after 'If enabled', it seems this oversight is quiet prevalent elsewhere in strings too

          Show
          Aparup Banerjee added a comment - This new setting is now integrated into master. ps: added comma to string after 'If enabled', it seems this oversight is quiet prevalent elsewhere in strings too
          Hide
          Adrian Greeve added a comment -

          I ran the upgrade and created some activities on the front page. I checkout out the navigation on the side and made sure that it was available and hidden depending on the setting.
          Test passed.
          Thanks Sam.

          Show
          Adrian Greeve added a comment - I ran the upgrade and created some activities on the front page. I checkout out the navigation on the side and made sure that it was available and hidden depending on the setting. Test passed. Thanks Sam.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This virus has been spread upstream, everybody will be infected soon. Congrats, you did it!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This virus has been spread upstream, everybody will be infected soon. Congrats, you did it! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: