Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.3
-
Fix Version/s: 2.3
-
Component/s: Navigation
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-30583-master -
Pull Master Diff URL:
Description
As required by moodle.org we don't want to display front page activities in the navigation.
Presently we use a local plugin to tidy up the navigation as we require, however it would be great to have a setting to control this.
Gliffy Diagrams
Attachments
Issue Links
- caused a regression
-
MDL-32182 Navigation lib generating PHP warning in role assignment
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
The code looks good. Is the fix version on this issue set correctly?
Thanks for looking at this Andrew, its up for integration now.
Indeed fix version is correct, as this is a new feature it will only be included on the master branch and the next master release will be 2.3.
Cheers
Sam
oops, stopping review - this is master only and we're not doing that for now.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
Uhm, sorry again but surely we should hold this until MDL-26155 is integrated and then use the new lang_string() artifact?
Ciao
Hi Eloy,
Hehe just to keep things fun I've created the following branch based off MDL-26155 so that this can still be reviewed/integrated today if you wish:
Branch: wip-MDL-30583-m23-after-MDL-26155
|
Diff url: https://github.com/samhemelryk/moodle/compare/wip-MDL-26155-m23...wip-MDL-30583-m23-after-MDL-26155
|
Fetch cmd: git fetch git://github.com/samhemelryk/moodle.git wip-MDL-30583-m23-after-MDL-26155
|
Cheers
Sam
The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.
This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.
This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P
Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
Rebased and afterMDL-26155 branch removed. Please use the original branch again
This new setting is now integrated into master.
ps: added comma to string after 'If enabled', it seems this oversight is quiet prevalent elsewhere in strings too 
I ran the upgrade and created some activities on the front page. I checkout out the navigation on the side and made sure that it was available and hidden depending on the setting.
Test passed.
Thanks Sam.
This virus has been spread upstream, everybody will be infected soon. Congrats, you did it!
Closing, ciao
Putting this up for peer-review now.