Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30585

Backport MDL-30340 and (2) subtasks to 21_STABLE

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.1.4
    • Component/s: Blocks
    • Labels:
    • Testing Instructions:
      Hide

      Testing should include:

      • Create block @ frontpage, playing with the 3 possible page contexts (system, frontpage only and frontpage-all).
      • Review all the rest of system-wide pages (my template, userprofile template, blogs, tags, notes), both with own defined blocks and inherited from frontpage's system-wide.
      • Review all the rest of contexts (course category, course, module), both with own defined blocks and inherited from all parent contexts.

      The only annoyances detected should be:

      • MDL-30564 - Separate course-categories admin interface and normal usage (varying pagetypes problem). It shows, when editing, "admin-xxx", and should be "coursecat xxxx", but it's not fixable until we solve the duality and apply correctly on each page-type.
      • MDL-30574 - Delete some incorrect "any page" options that should not exist (or add some missing ones, to decide in that issue). This is leading to some small inconsistencies in system => system inheritance (that IMO should be 100% forbidden, with each page showing its own pagetypes, but others may think the opposite and enable the "bring back" feature to all them).

      Ciao

      Show
      Testing should include: Create block @ frontpage, playing with the 3 possible page contexts (system, frontpage only and frontpage-all). Review all the rest of system-wide pages (my template, userprofile template, blogs, tags, notes), both with own defined blocks and inherited from frontpage's system-wide. Review all the rest of contexts (course category, course, module), both with own defined blocks and inherited from all parent contexts. The only annoyances detected should be: MDL-30564 - Separate course-categories admin interface and normal usage (varying pagetypes problem). It shows, when editing, "admin-xxx", and should be "coursecat xxxx", but it's not fixable until we solve the duality and apply correctly on each page-type. MDL-30574 - Delete some incorrect "any page" options that should not exist (or add some missing ones, to decide in that issue). This is leading to some small inconsistencies in system => system inheritance (that IMO should be 100% forbidden, with each page showing its own pagetypes, but others may think the opposite and enable the "bring back" feature to all them). Ciao
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:

      Description

      Once MDL-30340 has landed to master (2.2), it would be worth considering to backport it to 21_STABLE, where the issue was originally reported.

      It fixes some real annoyances happening there and the master patch applies 100% clean.

      For commodity, the complete patch is available already here:

      https://github.com/stronk7/moodle/compare/MOODLE_21_STABLE...MDL-30340.totus_tuus_21

      For your consideration. Ciao

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Integrator:
              Sam Hemelryk
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12