Moodle
  1. Moodle
  2. MDL-30598

scorm api.php was moved to loaddatamodel.php but accidentally reverted back

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.3
    • Component/s: SCORM
    • Labels:
    • Rank:
      33398

      Description

      need to dump api.php and replace it with loaddatamodel.php - this was done a while back (in 1.9 branch before 2.0 release) but somewhere along the lines it was reverted and now loaddatamodel.php isn't used anymore and api.php has a bunch of fixes that need to be transferred to loaddatamodel.php

        Activity

        Hide
        Christopher Tombleson added a comment -

        Fixed here:
        https://github.com/chtombleson/moodle/tree/master-MDL-30598

        Merged api.php into loaddatamodel.php

        Show
        Christopher Tombleson added a comment - Fixed here: https://github.com/chtombleson/moodle/tree/master-MDL-30598 Merged api.php into loaddatamodel.php
        Hide
        Dan Marsden added a comment -

        thanks Chris - have grabbed your change and fixed a few coding guideline issues with that file before I submit it for integration.

        This is only for master.

        Show
        Dan Marsden added a comment - thanks Chris - have grabbed your change and fixed a few coding guideline issues with that file before I submit it for integration. This is only for master.
        Hide
        Dan Marsden added a comment -

        submitting for integration - thanks for the help Chris!

        Show
        Dan Marsden added a comment - submitting for integration - thanks for the help Chris!
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks

        Show
        Dan Poltawski added a comment - Integrated, thanks
        Hide
        Ankit Agarwal added a comment -

        Hi Dan,

        I am not sure exactly if its related but, around 40% of the time I tried to load the scorm it gives out an error
        "Unable to find a SCORM API. Session will not be logged."

        The cases when it doesn't pop any error, everything works fine and grades are pushed back without any issue.
        Please advice if to pass or fail this test.

        Thanks

        Show
        Ankit Agarwal added a comment - Hi Dan, I am not sure exactly if its related but, around 40% of the time I tried to load the scorm it gives out an error "Unable to find a SCORM API. Session will not be logged." The cases when it doesn't pop any error, everything works fine and grades are pushed back without any issue. Please advice if to pass or fail this test. Thanks
        Hide
        Dan Marsden added a comment -

        the strict standards stuff could be causing that - there's some code for peer-review that might help in MDL-32507 - try turning strict standards off to see if it's more reliable?

        Show
        Dan Marsden added a comment - the strict standards stuff could be causing that - there's some code for peer-review that might help in MDL-32507 - try turning strict standards off to see if it's more reliable?
        Hide
        Ankit Agarwal added a comment -

        Thanks Dan,
        I set debug to E_ALL and it is much better now. No more errors.

        Passing this
        Thanks

        Show
        Ankit Agarwal added a comment - Thanks Dan, I set debug to E_ALL and it is much better now. No more errors. Passing this Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

        Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: