Moodle
  1. Moodle
  2. MDL-30601

Update MyMobile theme to use Final Version of Jquery Mobile.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:

      Description

      The mymobile theme currently uses an RC3 version of Jquery Mobile. Updating to the final release will increase performance and stability.

        Gliffy Diagrams

          Activity

          Hide
          Michael de Raadt added a comment -

          Keep up the good work, John.

          Show
          Michael de Raadt added a comment - Keep up the good work, John.
          Hide
          Rossiani Wijaya added a comment -

          Hi John,

          Thank you for supplying patch to improve Mobile theme.

          However I could not apply the patch due to trailing whitespaces.

          Could you update and resubmit the patch?

          Thanks

          Rosie.

          Show
          Rossiani Wijaya added a comment - Hi John, Thank you for supplying patch to improve Mobile theme. However I could not apply the patch due to trailing whitespaces. Could you update and resubmit the patch? Thanks Rosie.
          Hide
          John Stabinger added a comment -

          Could you be more specific? These are just updated files from the Jquery Mobile project...

          Show
          John Stabinger added a comment - Could you be more specific? These are just updated files from the Jquery Mobile project...
          Hide
          Rossiani Wijaya added a comment -

          When I tried to apply your patch to my local machine it showed the following error message:

          MDL-30601.diff:1008: trailing whitespace.
          /* 
          MDL-30601.diff:1327: trailing whitespace.
          // 
          MDL-30601.diff:1329: trailing whitespace.
          // 
          MDL-30601.diff:1334: trailing whitespace.
          // 
          MDL-30601.diff:1336: trailing whitespace.
          // 
          warning: squelched 175 whitespace errors
          warning: 180 lines add whitespace errors.
          

          Show
          Rossiani Wijaya added a comment - When I tried to apply your patch to my local machine it showed the following error message: MDL-30601.diff:1008: trailing whitespace. /* MDL-30601.diff:1327: trailing whitespace. // MDL-30601.diff:1329: trailing whitespace. // MDL-30601.diff:1334: trailing whitespace. // MDL-30601.diff:1336: trailing whitespace. // warning: squelched 175 whitespace errors warning: 180 lines add whitespace errors.
          Hide
          John Stabinger added a comment -

          This code was taken directly from the jquery mobile project. So I need to modify their code? Could you provide line #s or a method to do this in bulk as it is not my code.

          Show
          John Stabinger added a comment - This code was taken directly from the jquery mobile project. So I need to modify their code? Could you provide line #s or a method to do this in bulk as it is not my code.
          Hide
          Rossiani Wijaya added a comment -

          Hi John,

          I updated the patch to remove the trailing whitespaces.

          Submitting for integration review.

          Rosie

          Show
          Rossiani Wijaya added a comment - Hi John, I updated the patch to remove the trailing whitespaces. Submitting for integration review. Rosie
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          Obviously great to get this update in early so that it can be thoroughly tested.
          Of course being that it is master only this will have to wait until we split MOODLE_22_STABLE and master.
          However I believe that will either be tomorrow or next week so not long now, and then up for testing.
          Once we have reached that point I will integrate this

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, Obviously great to get this update in early so that it can be thoroughly tested. Of course being that it is master only this will have to wait until we split MOODLE_22_STABLE and master. However I believe that will either be tomorrow or next week so not long now, and then up for testing. Once we have reached that point I will integrate this Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrated now.
          I'm going to change testing instructions from none. => everything though.. this needs to be thoroughly tested!

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrated now. I'm going to change testing instructions from none. => everything though.. this needs to be thoroughly tested!
          Hide
          Aparup Banerjee added a comment -

          i've done some general usage testign with mymobile theme , stuff seems to be still working - passing

          Show
          Aparup Banerjee added a comment - i've done some general usage testign with mymobile theme , stuff seems to be still working - passing
          Hide
          Aparup Banerjee added a comment -

          i did notice that the listing of courses when there is only one course is rendered with a missing bottom line - in a sort of a tab effect.. if there are more to the list it seems fine as the rest of the list of tabs' fill up the missing line.

          Show
          Aparup Banerjee added a comment - i did notice that the listing of courses when there is only one course is rendered with a missing bottom line - in a sort of a tab effect.. if there are more to the list it seems fine as the rest of the list of tabs' fill up the missing line.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: