Moodle
  1. Moodle
  2. MDL-30603

Fix Zend file name lib/zend/validate/barcode/UpcA.php -> Upca.php for issues with case sensitive file systems (ZF-11080)

    Details

    • Testing Instructions:
      Hide

      no sure how to test this, at best maybe simply checking that the filename is correct as Mark reported it should be.

      Show
      no sure how to test this, at best maybe simply checking that the filename is correct as Mark reported it should be.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30603_m23
    • Rank:
      33403

      Description

      lib/zend/Zend/Validate/Barcode/UpcA.php should be lib/zend/Zend/Validate/Barcode/Upca.php

        Activity

        Hide
        Michael de Raadt added a comment -

        Hi, Mark.

        You might need to give us some clues with this one.

        Where is this string located? I went and did a quick search, but it didn't find the string.

        I don't want to sound doubtful, but how do you know this change needs to be made? Was there an error produced somewhere? Is there some source regarding this change? We're happy to fix this if it's a problem, but it would be good to know why.

        Show
        Michael de Raadt added a comment - Hi, Mark. You might need to give us some clues with this one. Where is this string located? I went and did a quick search, but it didn't find the string. I don't want to sound doubtful, but how do you know this change needs to be made? Was there an error produced somewhere? Is there some source regarding this change? We're happy to fix this if it's a problem, but it would be good to know why.
        Hide
        Michael de Raadt added a comment -

        Or do you mean the file should be renamed?

        My why question would still apply.

        Show
        Michael de Raadt added a comment - Or do you mean the file should be renamed? My why question would still apply.
        Hide
        Mark Nielsen added a comment -

        Sorry for the bland report. Yes, I'm requesting a file name change as the current case of the file name does not match the case found in ZendFramework's distribution.

        This did not come up as an error with Moodle code, but we do some customized work around the ZF library and this file name can mess things up, especially on a case insensitive file system. I was just hoping that we could fix the file name.

        Cheers!

        Show
        Mark Nielsen added a comment - Sorry for the bland report. Yes, I'm requesting a file name change as the current case of the file name does not match the case found in ZendFramework's distribution. This did not come up as an error with Moodle code, but we do some customized work around the ZF library and this file name can mess things up, especially on a case insensitive file system. I was just hoping that we could fix the file name. Cheers!
        Hide
        Michael de Raadt added a comment -

        Thanks for clarifying this.

        I'll pass this on to Aparup and see if we can get it sorted.

        Show
        Michael de Raadt added a comment - Thanks for clarifying this. I'll pass this on to Aparup and see if we can get it sorted.
        Hide
        Aparup Banerjee added a comment -

        grr just lost my comment by clicking on this link in post preview.

        link to correct file for ZF1.10.6

        I had basically also found this issue which gave a bit of background.

        Show
        Aparup Banerjee added a comment - grr just lost my comment by clicking on this link in post preview. link to correct file for ZF1.10.6 I had basically also found this issue which gave a bit of background.
        Hide
        Aparup Banerjee added a comment -

        This is up for Jerome's peer review seeing that zend libs are only used in webservices / mnet.

        Jerome or Mark, perhaps you can come up with a test as i have no idea how to test it.

        Show
        Aparup Banerjee added a comment - This is up for Jerome's peer review seeing that zend libs are only used in webservices / mnet. Jerome or Mark, perhaps you can come up with a test as i have no idea how to test it.
        Hide
        Jérôme Mouneyrac added a comment - - edited

        I don't see any issue to rename the file in the way it is supposed to be +1

        Show
        Jérôme Mouneyrac added a comment - - edited I don't see any issue to rename the file in the way it is supposed to be +1
        Hide
        Mark Nielsen added a comment -

        The pull request looks good to me as well.

        Show
        Mark Nielsen added a comment - The pull request looks good to me as well.
        Hide
        Aparup Banerjee added a comment -

        thanks, submitting to The Integrators

        Show
        Aparup Banerjee added a comment - thanks, submitting to The Integrators
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (20, 21, 22 and master)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (20, 21, 22 and master)
        Hide
        moodle.com added a comment -

        Hi, Mark.

        Could you please test this fix?

        Show
        moodle.com added a comment - Hi, Mark. Could you please test this fix?
        Hide
        Mark Nielsen added a comment -

        Eloy, I'm not seeing this anywhere in the repository and the pull request URLs still show a difference. See https://github.com/moodle/moodle/tree/master/lib/zend/Zend/Validate/Barcode

        Show
        Mark Nielsen added a comment - Eloy, I'm not seeing this anywhere in the repository and the pull request URLs still show a difference. See https://github.com/moodle/moodle/tree/master/lib/zend/Zend/Validate/Barcode
        Hide
        Aparup Banerjee added a comment -

        Mark, this patch is currently @ git://git.moodle.org/integration.git - that's where we do our testing before rolling up any release into git://git.moodle.org/moodle.git.

        Show
        Aparup Banerjee added a comment - Mark, this patch is currently @ git://git.moodle.org/integration.git - that's where we do our testing before rolling up any release into git://git.moodle.org/moodle.git.
        Hide
        David Mudrak added a comment -

        Let's rock'n'test (I hope Mark doesn't mind)

        Show
        David Mudrak added a comment - Let's rock'n'test (I hope Mark doesn't mind)
        Hide
        Aparup Banerjee added a comment -

        Rock on david!

        Show
        Aparup Banerjee added a comment - Rock on david!
        Hide
        David Mudrak added a comment -

        Yup, looking good

        git show integration/MOODLE_

        {20,21,22}

        _STABLE:lib/zend/Zend/Validate/Barcode

        and

        git show integration/master:lib/zend/Zend/Validate/Barcode

        show that the file is Upca.php now. Thanks for spotting this Mark and fixing that Apu!

        Show
        David Mudrak added a comment - Yup, looking good git show integration/MOODLE_ {20,21,22} _STABLE:lib/zend/Zend/Validate/Barcode and git show integration/master:lib/zend/Zend/Validate/Barcode show that the file is Upca.php now. Thanks for spotting this Mark and fixing that Apu!
        Hide
        Mark Nielsen added a comment -

        I just checked as well, looks great in those locations.

        Show
        Mark Nielsen added a comment - I just checked as well, looks great in those locations.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

        Now... disconnect, relax and enjoy the next days, yay!

        Closing...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: