Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30607

Once you override your email address in your messaging preferences you cannot un-override it

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.3, 2.2, 2.3
    • 2.1.4, 2.2.1
    • Messages
    • Any
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MDL-30607_override_email
    • Hide

      Go to your messaging preferences and add an email address that is different from the default one. Save.

      Clear the email box and save. Check that the box is empty when the page reloads.

      Show
      Go to your messaging preferences and add an email address that is different from the default one. Save. Clear the email box and save. Check that the box is empty when the page reloads.

    Description

      If you try to clear the email address box on your messaging preferences and save the previous value reappears.

      This was introduced by MDL-27171. Specifically changing this...

      if (isset($form->email_email)) {
          $preferences['message_processor_email_email'] = $form->email_email;

      to this...

      if (isset($form->email_email) && !empty($form->email_email)) {
          $preferences['message_processor_email_email'] = $form->email_email;

      Either reverting that change or making that check a bit smarter should do the trick.

      Attachments

        Issue Links

          Activity

            People

              andyjdavis Andrew Davis
              andyjdavis Andrew Davis
              Sam Hemelryk Sam Hemelryk
              Aparup Banerjee Aparup Banerjee
              Ankit Agarwal Ankit Agarwal
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jan/12