Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30607

Once you override your email address in your messaging preferences you cannot un-override it

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Messages
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Go to your messaging preferences and add an email address that is different from the default one. Save.

      Clear the email box and save. Check that the box is empty when the page reloads.

      Show
      Go to your messaging preferences and add an email address that is different from the default one. Save. Clear the email box and save. Check that the box is empty when the page reloads.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-30607_override_email

      Description

      If you try to clear the email address box on your messaging preferences and save the previous value reappears.

      This was introduced by MDL-27171. Specifically changing this...

      if (isset($form->email_email)) {
          $preferences['message_processor_email_email'] = $form->email_email;

      to this...

      if (isset($form->email_email) && !empty($form->email_email)) {
          $preferences['message_processor_email_email'] = $form->email_email;

      Either reverting that change or making that check a bit smarter should do the trick.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Aparup Banerjee
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jan/12