[MDL-30607] Once you override your email address in your messaging preferences you cannot un-override it - Moodle Tracker

XML

Word

Printable

Database:

Any
Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/andyjdavis/moodle.git
Pull Master Branch:
~~MDL-30607~~_override_email
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-30607_override_email
Testing Instructions:

Hide

Go to your messaging preferences and add an email address that is different from the default one. Save.

Clear the email box and save. Check that the box is empty when the page reloads.

Show
Go to your messaging preferences and add an email address that is different from the default one. Save. Clear the email box and save. Check that the box is empty when the page reloads.

If you try to clear the email address box on your messaging preferences and save the previous value reappears.

This was introduced by ~~MDL-27171~~. Specifically changing this...

if (isset($form->email_email)) {

    $preferences['message_processor_email_email'] = $form->email_email;

to this...

if (isset($form->email_email) && !empty($form->email_email)) {

    $preferences['message_processor_email_email'] = $form->email_email;

Either reverting that change or making that check a bit smarter should do the trick.

is a regression caused by

MDL-27171 Improved configuration options for the messaging system

Participants:: Andrew Davis, Ankit Agarwal, Aparup Banerjee, Eloy Lafuente (stronk7), Sam Hemelryk

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo