Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 2.2, 2.3
-
Fix Version/s: 2.2.2
-
Component/s: Administration, Blocks
-
Labels:
-
Database:Any
-
Testing Instructions:
- Log in as admin
- In settings block search "admin" (On left side bottom)
- Make sure block appears on left.
-
Affected Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-mdl-30608
-
Pull Master Diff URL:
Description
If you log in as admin and search for something in the Settings block your search results are displayed but all the blocks have disappeared.
Gliffy Diagrams
Issue Links
Activity
Increasing the priority on this because it's really annoying me.
I have to get going to the night IMMEDIATELY, however the solution for this problem is simple.
Raj wanna turn it into a branch for me and peer-review?
If not no probs I'll do it tomorrow when I am online.
|
|
diff --git a/admin/search.php b/admin/search.php
|
index 55d93c0..99ddf7e 100644
|
--- a/admin/search.php
|
+++ b/admin/search.php
|
@@ -10,14 +10,14 @@ $query = trim(optional_param('query', '', PARAM_NOTAGS)); // Search string
|
$PAGE->set_context(get_context_instance(CONTEXT_SYSTEM));
|
$PAGE->set_course($SITE);
|
|
+admin_externalpage_setup('search', '', array('query' => $query)); // now hidden page
|
+
|
$adminroot = admin_get_root(); // need all settings here
|
$adminroot->search = $query; // So we can reference it in search boxes later in this invocation
|
$statusmsg = '';
|
$errormsg = '';
|
$focus = '';
|
|
-admin_externalpage_setup('search', '', array('query' => $query)); // now hidden page
|
-
|
// now we'll deal with the case that the admin has submitted the form with changed settings
|
if ($data = data_submitted() and confirm_sesskey()) {
|
if (admin_write_settings($data)) {
|
|
Cheers
Sam
Ohh and remove `$PAGE->set_course($SITE);` that is totally unnecessary!
Thanks Sam, for spot-on patch.
I have created branches and pushing it for peer-review.
Thanks for working on this, Sam.
That changed worked for me.
Pushing it for integration review...
Integrated, thanks!
And test passed, I was really curious because I use the search facility a lot and had not noticed that at all. Now works properly.
This virus has been spread upstream, everybody will be infected soon. Congrats, you did it!
Closing, ciao 
This does not seem to affect the 2.1 branch.
I couldn't see any recent change to the search.php file itself, so I assume it has something to do with the layout.
Perhaps this is related to
MDL-30340, which has not yet been backported.