Moodle

drop all upgrade and migration scripts early in 2.3dev

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3
  • Fix Version/s: 2.3
  • Component/s: General
  • Labels:
  • Testing Instructions:
    Hide

    1/ test upgrade from 2.2 (it may not work before the version bump)
    2/ test fresh install
    3/ test install is blocked from 2.1 or earlier
    4/ test 2.1 upgrade works from 1.9 and fails from 1.9dev
    5/ try restore from 1.9 backup with all supported modules

    Show
    1/ test upgrade from 2.2 (it may not work before the version bump) 2/ test fresh install 3/ test install is blocked from 2.1 or earlier 4/ test 2.1 upgrade works from 1.9 and fails from 1.9dev 5/ try restore from 1.9 backup with all supported modules
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    w52_MDL-30610_m23_upgradepurge
  • Pull Master Diff URL:

Description

It was planned some time ago to require Moodle 2.2 when upgrading to 2.3.
I have also discovered that the environment test accepts dev version for requirements which is not correct.

Issue Links

caused a regression

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31124 MDL-30610 changes breaks restore of 1.9 backups

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31333 MDL-30610 changes breaks restore of 1.9 backups (and II)

  • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
is blocked by

Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30604 Add Moodle 2.2.0 upgrade line to all the upgrade.php scripts

  • Critical - Crashes server, loss of data, severe memory leak
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30605 Decide Moodle 2.3 requirements and push them to environment.xml

  • Critical - Crashes server, loss of data, severe memory leak
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yay, nice Petr, thanks!

TO INTEGRATORS: This cannot be integrated before:

  • The two blockers above are done: (MDL-30604 and) MDL-30605.
  • The very first weeks of "sync" integration (22_STABLE & master) are running.

(so I'd say that this cool cleanup won't happen before Xmas)

Show
Eloy Lafuente (stronk7) added a comment - Yay, nice Petr, thanks! TO INTEGRATORS: This cannot be integrated before: The two blockers above are done: ( MDL-30604 and) MDL-30605 . The very first weeks of "sync" integration (22_STABLE & master) are running. (so I'd say that this cool cleanup won't happen before Xmas)
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Petr Škoda added a comment - - edited

rebased, env requirement in separate issue

Show
Petr Škoda added a comment - - edited rebased, env requirement in separate issue
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Petr Škoda added a comment -

rebased, ciao

Show
Petr Škoda added a comment - rebased, ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Not sure about which criteria you've followed to, sometimes yes/no, delete/keep these lines:

// Moodle v2.2.0 release upgrade line
// Put any upgrade step following this

Nor why you've introduced these in main script:

////////////////////////////////////////
///upgrade supported only from 2.2.x ///
////////////////////////////////////////

But who cares, I don't. Ciao

Show
Eloy Lafuente (stronk7) added a comment - Not sure about which criteria you've followed to, sometimes yes/no, delete/keep these lines: // Moodle v2.2.0 release upgrade line // Put any upgrade step following this Nor why you've introduced these in main script: //////////////////////////////////////// ///upgrade supported only from 2.2.x /// //////////////////////////////////////// But who cares, I don't. Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

I've added one commit bumping to 2012020200.00. So diverging has started, yay!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks! I've added one commit bumping to 2012020200.00. So diverging has started, yay! Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Added one more commit adding one (unreachable) upgrade_main_savepoint() call (within 2011120500) to have all the upgrade blocks balanced and passing the automated CI checks.

Show
Eloy Lafuente (stronk7) added a comment - Added one more commit adding one (unreachable) upgrade_main_savepoint() call (within 2011120500) to have all the upgrade blocks balanced and passing the automated CI checks.
Hide
Permalink
Petr Škoda added a comment -

thanks! the upgrade line inconsistence was introduced over the time when I was fixing merge conflicts...

Show
Petr Škoda added a comment - thanks! the upgrade line inconsistence was introduced over the time when I was fixing merge conflicts...
Hide
Permalink
Jason Fowler added a comment - - edited

Petr, please explain why I am testing upgrading from 1.9 to 2.1 for code that was only introduced/modified in 2.3 ...

The dev/integration version of 1.9 still allows me to upgrade to 2.1 the test instructions says it shouldn't ...

Show
Jason Fowler added a comment - - edited Petr, please explain why I am testing upgrading from 1.9 to 2.1 for code that was only introduced/modified in 2.3 ... The dev/integration version of 1.9 still allows me to upgrade to 2.1 the test instructions says it shouldn't ...
Hide
Permalink
Jason Fowler added a comment -

I'll pass this, based on the fact that the code does as it is supposed to, even if the test instructions include additional things that don't directly relate to the issue here

Show
Jason Fowler added a comment - I'll pass this, based on the fact that the code does as it is supposed to, even if the test instructions include additional things that don't directly relate to the issue here
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Side note, point 4 of testing instructions is, if I'm not wrong, one (wrong) leftover step, because the "dev" problem was fixed and tested by MDL-30605. So well done, Jason.

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Side note, point 4 of testing instructions is, if I'm not wrong, one (wrong) leftover step, because the "dev" problem was fixed and tested by MDL-30605 . So well done, Jason. Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao
Hide
Permalink
Tim Hunt added a comment -

This caused a fatal regression. The code in mod/workshop/form/accumulative/db/upgradelib.php that was deleted is used by restore from Moodle 1.9 code.

I will open a new issue.

Show
Tim Hunt added a comment - This caused a fatal regression. The code in mod/workshop/form/accumulative/db/upgradelib.php that was deleted is used by restore from Moodle 1.9 code. I will open a new issue.
Hide
Permalink
Ashley Holman added a comment -

Hi, this seems a bit drastic to drop all of this upgrade code. This complicates the upgrade path for those who are not yet on 2.2. Dropping 1.9 is fair enough but why drop 2.1 which came out less than a year ago? Given that there are two major releases per year now, and institutions will generally only have an opportunity to upgrade once per year, why not at least include the last 2 major versions so that a once-yearly upgrade is not complicated with having to create multiple code bases for the upgrade?

Show
Ashley Holman added a comment - Hi, this seems a bit drastic to drop all of this upgrade code. This complicates the upgrade path for those who are not yet on 2.2. Dropping 1.9 is fair enough but why drop 2.1 which came out less than a year ago? Given that there are two major releases per year now, and institutions will generally only have an opportunity to upgrade once per year, why not at least include the last 2 major versions so that a once-yearly upgrade is not complicated with having to create multiple code bases for the upgrade?

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: