Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30613

$FULLME should not be used for https detection

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.2, 2.3
    • 2.2.1
    • General
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_22_STABLE
    • w51_MDL-30613_m23_FULLME
    • Hide

      1/ make sure standard sites with adn without ssl work as before (test especially login with and without automatic guest login)
      2/ try sites with loginhttps
      3/ in head try LTI and gravatar on ssl sites

      Show
      1/ make sure standard sites with adn without ssl work as before (test especially login with and without automatic guest login) 2/ try sites with loginhttps 3/ in head try LTI and gravatar on ssl sites

    Description

      $FULLME ca not be used for https detection because it breaks ssl proxies, instead we must use $CFG->httpswwwroot.

      I am going to comment in the pagelib because it seems ppl copy pasted it from there - it is a special case and it is intentionally not compatible with ssl proxies...

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda
              skodak Petr Skoda
              Aparup Banerjee Aparup Banerjee
              Rajesh Taneja Rajesh Taneja
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jan/12