Moodle
  1. Moodle
  2. MDL-30623

Guest are continually asked for an enrolment password when trying to enter courses they should have access to

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.1
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      1/ use DB editor and set some enrol->password fields from guest plugin to NULL
      2/ make sure user can not access
      3/ upgrade and verify guest access is now possible
      4/ try upgrade from 1.9

      Show
      1/ use DB editor and set some enrol->password fields from guest plugin to NULL 2/ make sure user can not access 3/ upgrade and verify guest access is now possible 4/ try upgrade from 1.9
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w50_MDL-30623_m23_guest
    • Rank:
      33431

      Description

      MDL-30148 added 3 tighter checks on $instance->password in enrol/guest/lib.php

      eg

      -        if (empty($instance->password)) {
      +        if ($instance->password === '') {
      

      Since the default value of this field in the database is actually NULL this now breaks sites like moodle.org with a lot of guest access by forcing everyone to type a guest password.

        Issue Links

          Activity

          Martin Dougiamas created issue -
          Martin Dougiamas made changes -
          Field Original Value New Value
          Link This issue is a regression caused by MDL-30148 [ MDL-30148 ]
          Martin Dougiamas made changes -
          Priority Minor [ 4 ] Blocker [ 1 ]
          Martin Dougiamas made changes -
          Labels triaged
          Martin Dougiamas made changes -
          Fix Version/s STABLE Sprint 16 [ 11350 ]
          Martin Dougiamas made changes -
          Assignee moodle.com [ moodle.com ] Sam Hemelryk [ samhemelryk ]
          Michael de Raadt made changes -
          Labels triaged sprinting triaged
          Petr Škoda made changes -
          Assignee Sam Hemelryk [ samhemelryk ] Petr Škoda (skodak) [ skodak ]
          Petr Škoda made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w50_MDL-30623_m23_guest
          Pull Master Branch w50_MDL-30623_m23_guest
          Pull from Repository git://github.com/skodak/moodle.git
          Fix Version/s 2.2.1 [ 11456 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s STABLE Sprint 16 [ 11350 ]
          Testing Instructions 1/ use DB editor and set some enrol->password fields from guest plugin to NULL
          2/ make sure user can not access
          3/ upgrade and verify guest access is now possible
          4/ try upgrade from 1.9
          Pull 2.2 Diff URL https://github.com/skodak/moodle/compare/MOODLE_22_STABLE...w50_MDL-30623_m22_guest
          Pull 2.2 Branch w50_MDL-30623_m22_guest
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Currently in integration Yes [ 10041 ]
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.3 [ 10657 ]
          Gerard Caulfield made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester gerry
          Gerard Caulfield made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 09/Dec/11

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: