Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30627

M.core.dialogue allows for a negative top location

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.3, 2.2, 2.3
    • 2.1.4, 2.2.1
    • General
    • MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • MOODLE_21_STABLE, MOODLE_22_STABLE
    • MDL-30627-master-1
    • Moderate
    • Hide
      • Add the 'Community finder' block to a page and select 'Search'
      • Submit the form to search for courses
      • find a course with a comment
      • make your window small
      • click the comments button

      This is much more pronounced on non-core uses of M.core.dialogue which specify a larger hieght

      Show
      Add the 'Community finder' block to a page and select 'Search' Submit the form to search for courses find a course with a comment make your window small click the comments button This is much more pronounced on non-core uses of M.core.dialogue which specify a larger hieght

    Description

      In enrol/yui/notification/notification.js under the centerDialogue function, the top and left values of the dialogue box are calculated based upon the bounding box for the page.

      However, these don't take into account that the dialogue could be larger than the window (e.g. if you have a very small window size set for some reason).
      If this is the case, then the dialogue disappears off the top of the screen.

      I suggest setting a minimum top/left of around 15px

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Sam Hemelryk Sam Hemelryk
              Aparup Banerjee Aparup Banerjee
              Adrian Greeve Adrian Greeve
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Jan/12