Details

    • Testing Instructions:
      Hide
      1. With javascript enabled in one browser (your choice) visit some long/short/complicated/simple moodle forms and verify they function correctly (no specific instructions - give the forms a good work out).
        1. Some good forms to test:
          1. Quiz settings
          2. Workshop settings
          3. Choice settings
          4. Course settings
          5. Grade item settings
          6. Backup Course (all steps)
          7. Restore Course (all steps)
      2. In all supported browsers test the functionality of the new javascript shortened forms for the "Choice settings" form.
      3. In one browser, disable javascript and make sure that the forms are still usable (but not collapsible and missing "Show more.../Show less" links). (Test the "Quiz settings" form)

      Note for testers: (Assignment has a known bug which means the sections show as expanded by default - exclude this from the tests).

      Show
      With javascript enabled in one browser (your choice) visit some long/short/complicated/simple moodle forms and verify they function correctly (no specific instructions - give the forms a good work out). Some good forms to test: Quiz settings Workshop settings Choice settings Course settings Grade item settings Backup Course (all steps) Restore Course (all steps) In all supported browsers test the functionality of the new javascript shortened forms for the "Choice settings" form. In one browser, disable javascript and make sure that the forms are still usable (but not collapsible and missing "Show more.../Show less" links). (Test the "Quiz settings" form) Note for testers: (Assignment has a known bug which means the sections show as expanded by default - exclude this from the tests).
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30637-master

      Description

      As discussed in http://moodle.org/mod/forum/discuss.php?d=191549, we've simplified the forms making them easier to use and navigate.

      This enhancement works by:

      • always displaying the 'General' section and closing all others by default;
      • always displaying a section with a required element;
      • opening any section which contains validation errors;
      • opening any section which was previously open on previous submit (e.g. when adding new choices);
      • displaying elements which are coded as expanded by default (e.g. $mform->setExpanded('foo'); and
      • removing the 'Show Advanced' button (using JS).

      There are still a couple of minor issues that we're aware of and working to address:

      • repeated elements are not shown by default because none of them are required until they're submitted - we've fixed it for the 'choice' module, and we're working on extending it to all affected modules;

      From the positive comments we've received so far, we'd like to submit it for integration into master.

        Gliffy Diagrams

          Attachments

          1. advanced_mock_hideadv.jpg
            advanced_mock_hideadv.jpg
            13 kB
          2. advanced_mock_showadv.jpg
            advanced_mock_showadv.jpg
            11 kB
          3. advanced_mock_showless.jpg
            advanced_mock_showless.jpg
            12 kB
          4. advanced_mock_showmore.jpg
            advanced_mock_showmore.jpg
            10 kB
          5. padding.png
            padding.png
            21 kB
          6. shortforms.jpg
            shortforms.jpg
            65 kB

            Issue Links

              Activity

                People

                • Votes:
                  21 Vote for this issue
                  Watchers:
                  31 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/13