Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Test 1:
      grep -Ri PARAM_INTEGER .
      and make sure it's not used in code. Only declaration in lib/moodlelib.php

      Test 2:
      Review changes and try find any silly mistake.

      Show
      Test 1: grep -Ri PARAM_INTEGER . and make sure it's not used in code. Only declaration in lib/moodlelib.php Test 2: Review changes and try find any silly mistake.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-mdl-30651
    • Rank:
      33468

      Description

      PARAM_INTEGER was deprecated in 2.0, please replace it with PARAM_INT and remove PARAM_INTEGER declaration.

        Issue Links

          Activity

          Hide
          Rajesh Taneja added a comment -

          Declaration is not removed for 3rd party plugin compatibility.

          Show
          Rajesh Taneja added a comment - Declaration is not removed for 3rd party plugin compatibility.
          Hide
          Rossiani Wijaya added a comment -

          Hi Raj,

          I think the declaration should be removed. The notice has been there since 2009.

          Other than that, the patch looks good.

          Show
          Rossiani Wijaya added a comment - Hi Raj, I think the declaration should be removed. The notice has been there since 2009. Other than that, the patch looks good.
          Hide
          Rajesh Taneja added a comment -

          Thanks Rossie,

          MDL-32976 has been opened to take care of this.

          Show
          Rajesh Taneja added a comment - Thanks Rossie, MDL-32976 has been opened to take care of this.
          Hide
          Dan Poltawski added a comment -

          Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

          Show
          Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
          Hide
          Rajesh Taneja added a comment -

          Branch re-based,
          Pushing it for integration review.

          Show
          Rajesh Taneja added a comment - Branch re-based, Pushing it for integration review.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Rajesh Taneja added a comment -

          Branch re-based.

          Show
          Rajesh Taneja added a comment - Branch re-based.
          Hide
          Dan Poltawski added a comment -

          Thanks Raj, i've integrated this now

          Show
          Dan Poltawski added a comment - Thanks Raj, i've integrated this now
          Hide
          Dan Poltawski added a comment -

          No non moodlelib PARAM_INTEGERs found

          Show
          Dan Poltawski added a comment - No non moodlelib PARAM_INTEGERs found
          Hide
          Aparup Banerjee added a comment -

          yay, it works!

          This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week.

          Thank you all for taking the time to get us here.

          cheers!

          Show
          Aparup Banerjee added a comment - yay, it works! This issue has been put through rigorous processes and finally swam upstream along with some 65 others this week. Thank you all for taking the time to get us here. cheers!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: