Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30658

advcheckbox bit of lib/form/form.js broken on stable branches since MDL-27045

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3
    • Fix Version/s: 2.0.7, 2.1.4
    • Component/s: Forms Library
    • Labels:
      None
    • Testing Instructions:
      Hide

      One place to test this

      1. On the quiz settings from, try enabling and disabling the close date.
      2. Verify the date selector becomes enabled and disabled.
      3. Verify that the 'after the quiz is closed' review settings become enabled and disabled.

      Show
      One place to test this 1. On the quiz settings from, try enabling and disabling the close date. 2. Verify the date selector becomes enabled and disabled. 3. Verify that the 'after the quiz is closed' review settings become enabled and disabled.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:

      Description

      Grrr! I am an idiot. I manage to screw up cherry-picking the fix for MDL-27045 onto the stable branches, so the stable branches have the wrong code. I am doing a fix now.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              timhunt Tim Hunt added a comment -

              Note, this does not affect 2.2 or master.

              Show
              timhunt Tim Hunt added a comment - Note, this does not affect 2.2 or master.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated, thanks! Now the lib/form/form.js file is 100% the same, for 20, 21, 22 and master.

              Thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! Now the lib/form/form.js file is 100% the same, for 20, 21, 22 and master. Thanks!
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Tim, passing this now

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Tim, passing this now
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Yes, you did it!

              Now your code is part of the best weeklies released ever, many thanks!

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you did it! Now your code is part of the best weeklies released ever, many thanks! Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jan/12