[MDL-30668] Prevent the grader report from storing serialized data in the user_preferences table - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2, 2.7
Fix Version/s: 2.6.5, 2.7.2
Component/s: Gradebook
Labels:
- ci
- netspot
- partner
- triaged

Database:

Any
Affected Branches:
MOODLE_22_STABLE, MOODLE_27_STABLE
Fixed Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE
Epic Link:
Gradebook 2014
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-~~MDL-30668~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/master...wip-MDL-30668-master
Testing Instructions:
Hide

BEFORE UPGRADE (or just revert the commit before testing since there is no upgrade step):

Create several courses with grade categories in them

View the grader report, collapse/aggregate some of categories. Remember the state (for example leave it open and continue in other browser tabs)

UPGRADE CODE

Open the grader report in the same courses and make sure it looks the same.

Try collapsing categories, refresh page, make sure it remembers settings.
Show
BEFORE UPGRADE (or just revert the commit before testing since there is no upgrade step): Create several courses with grade categories in them View the grader report, collapse/aggregate some of categories. Remember the state (for example leave it open and continue in other browser tabs) UPGRADE CODE Open the grader report in the same courses and make sure it looks the same. Try collapsing categories, refresh page, make sure it remembers settings.

Story Points:
20
Sprint:
BACKEND Sprint 15

Description

See ~~MDL-20245~~. When categories are collapsed on the grader report it appears than an array is serialized and stored in the user_preferences table. This table is really for simple name value pairs.

It would be good if we could avoid storing serialized data and instead only stored human readable data.

Attachments

Issue Links

blocks

MDL-46739 Allow to store long user preferences

Reopened

has a non-specific relationship to

MDL-20245 Allow bigger values (up to 1333 chars) in user preferences, alleviating some problems with grader report

Closed

has been marked as being related by

MDL-74231 Grader report throws PHP 8.0 exception

Closed

MDL-42271 "Coding Error" in maximizing and minimizing gradebook categories

Closed

MDL-43739 Storing sortorder of courses on my_home page fails if user is enrolled in a lot (100+) of courses

Closed

is duplicated by

MDL-45521 Error on Grader report

Closed

MDL-45911 Coding error detected

Closed

Testing discovered

MDL-47128 Cleanup of unnecessary gradebook user preferences

Closed

will help resolve

MDL-42903 Grader report: cliking on "aggregates only" raises an exception

Closed

MDL-48237 user_preferences table "value" column too small for some gradebooks when "collapsing" sections

Closed

(2 is duplicated by, 1 Testing discovered, 2 will help resolve)

Activity

People

Assignee:: Marina Glancy

Reporter:: Andrew Davis

Peer reviewer:: Damyon Wiese

Integrator:: Dan Poltawski

Tester:: Andrew Davis

Participants:: Andrew Davis, CiBoT, Damyon Wiese, Daniel M. Zimmerman, Dan Poltawski, Jon Daley, Kirill Astashov, KITA Toshihiro, Marina Glancy, Martin Dougiamas, Petras Virzintas, Tim Hunt

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 14 Vote for this issue

Watchers:: 24 Start watching this issue

Dates

Created:: 09/Dec/11 7:39 PM

Updated:: 20/Mar/22 7:55 PM

Resolved:: 15/Aug/14 1:18 AM

Fix Release Date:: 8/Sep/14