Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30668

Prevent the grader report from storing serialized data in the user_preferences table

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      BEFORE UPGRADE (or just revert the commit before testing since there is no upgrade step):

      1. Create several courses with grade categories in them
      2. View the grader report, collapse/aggregate some of categories. Remember the state (for example leave it open and continue in other browser tabs)
      3. UPGRADE CODE
      4. Open the grader report in the same courses and make sure it looks the same.
      5. Try collapsing categories, refresh page, make sure it remembers settings.
      Show
      BEFORE UPGRADE (or just revert the commit before testing since there is no upgrade step): Create several courses with grade categories in them View the grader report, collapse/aggregate some of categories. Remember the state (for example leave it open and continue in other browser tabs) UPGRADE CODE Open the grader report in the same courses and make sure it looks the same. Try collapsing categories, refresh page, make sure it remembers settings.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30668-master
    • Pull Master Diff URL:
    • Story Points:
      20
    • Sprint:
      BACKEND Sprint 15

      Description

      See MDL-20245. When categories are collapsed on the grader report it appears than an array is serialized and stored in the user_preferences table. This table is really for simple name value pairs.

      It would be good if we could avoid storing serialized data and instead only stored human readable data.

        Attachments

          Issue Links

          blocks

          Improvement - An enhancement to an existing Moodle feature. MDL-46739 Allow to store long user preferences

          • Minor - Minor loss of function where workaround is possible
          • Reopened
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-20245 Allow bigger values (up to 1333 chars) in user preferences, alleviating some problems with grader report

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42271 "Coding Error" in maximizing and minimizing gradebook categories

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43739 Storing sortorder of courses on my_home page fails if user is enrolled in a lot (100+) of courses

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45521 Error on Grader report

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45911 Coding error detected

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-47128 Cleanup of unnecessary gradebook user preferences

          • Minor - Minor loss of function where workaround is possible
          • Open
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42903 Grader report: cliking on "aggregates only" raises an exception

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48237 user_preferences table "value" column too small for some gradebooks when "collapsing" sections

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              14 Vote for this issue
              Watchers:
              24 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Sep/14