Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30669

'Sticky' site wide blocks in 2.2 can be deleted from the course page (by an admin)

    XMLWordPrintable

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Create a site wide block.
      2. Set page contexts to 'Display throughout the entire site'.
        • Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the following: ('System','Any page').
      3. Create another block on the front page and set the page context to 'Display on the front page and any pages added to the front page'.
        • Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Front page','Display on the front page and any pages added to the front page').
      4. Enter a course and create a course wide block.
      5. Set Display on page types to 'Any page'.
        • Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Course:XXXX','Any page').
      6. Try deleting a block in an activity. Check that no additional error message is displayed.
      Show
      Create a site wide block. Set page contexts to 'Display throughout the entire site'. Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the following: ('System','Any page'). Create another block on the front page and set the page context to 'Display on the front page and any pages added to the front page'. Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Front page','Display on the front page and any pages added to the front page'). Enter a course and create a course wide block. Set Display on page types to 'Any page'. Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Course:XXXX','Any page'). Try deleting a block in an activity. Check that no additional error message is displayed.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30669-master
    • Pull Master Diff URL:

      Description

      After setting up a Front Page block set to 'Display throughout the site' (i.e. adding a sticky block), the block can be deleted from within a course (if the user is an admin) without any warning that this course-level editing is deleting a block from the entire site. This is in contrast to the 1.9 behaviour, where sticky blocks did not have editing buttons available within the course context.

      Replication steps:
      1. Log in as Admin.
      2. Add a block to the Front Page.
      3. Set block to be visible every where within the site.
      4. Browse to a course.
      5. Turn editing on.
      6. Click the 'delete' button on the site wide block
      -> Block disappears from the entire site.

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31741 Hyperlinks in an HTML block disappear

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-36649 "site wide" blocks are far too easy to delete (no warning)

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              drex Mark Drechsler
              Peer reviewer:
              Tim Hunt Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Frédéric Massart Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/13