Moodle
  1. Moodle
  2. MDL-30669

'Sticky' site wide blocks in 2.2 can be deleted from the course page (by an admin)

    Details

    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Create a site wide block.
      2. Set page contexts to 'Display throughout the entire site'.
        • Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the following: ('System','Any page').
      3. Create another block on the front page and set the page context to 'Display on the front page and any pages added to the front page'.
        • Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Front page','Display on the front page and any pages added to the front page').
      4. Enter a course and create a course wide block.
      5. Set Display on page types to 'Any page'.
        • Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Course:XXXX','Any page').
      6. Try deleting a block in an activity. Check that no additional error message is displayed.
      Show
      Create a site wide block. Set page contexts to 'Display throughout the entire site'. Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the following: ('System','Any page'). Create another block on the front page and set the page context to 'Display on the front page and any pages added to the front page'. Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Front page','Display on the front page and any pages added to the front page'). Enter a course and create a course wide block. Set Display on page types to 'Any page'. Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Course:XXXX','Any page'). Try deleting a block in an activity. Check that no additional error message is displayed.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30669-master
    • Rank:
      33487

      Description

      After setting up a Front Page block set to 'Display throughout the site' (i.e. adding a sticky block), the block can be deleted from within a course (if the user is an admin) without any warning that this course-level editing is deleting a block from the entire site. This is in contrast to the 1.9 behaviour, where sticky blocks did not have editing buttons available within the course context.

      Replication steps:
      1. Log in as Admin.
      2. Add a block to the Front Page.
      3. Set block to be visible every where within the site.
      4. Browse to a course.
      5. Turn editing on.
      6. Click the 'delete' button on the site wide block
      -> Block disappears from the entire site.

        Issue Links

          Activity

          Mark Drechsler created issue -
          Michael de Raadt made changes -
          Field Original Value New Value
          Testing Instructions 1. Log in as Admin.
          2. Add a block to the Front Page.
          3. Set block to be visible every where within the site.
          4. Browse to a course.
          5. Turn editing on.
          6. Click the 'delete' button on the site wide block
          -> Block disappears from the entire site.
          Description After setting up a Front Page block set to 'Display throughout the site' (i.e. adding a sticky block), the block can be deleted from within a course (if the user is an admin) without any warning that this course-level editing is deleting a block from the entire site. This is in contrast to the 1.9 behaviour, where sticky blocks did not have editing buttons available within the course context. After setting up a Front Page block set to 'Display throughout the site' (i.e. adding a sticky block), the block can be deleted from within a course (if the user is an admin) without any warning that this course-level editing is deleting a block from the entire site. This is in contrast to the 1.9 behaviour, where sticky blocks did not have editing buttons available within the course context.

          *Replication steps:*
          1. Log in as Admin.
          2. Add a block to the Front Page.
          3. Set block to be visible every where within the site.
          4. Browse to a course.
          5. Turn editing on.
          6. Click the 'delete' button on the site wide block
          -> Block disappears from the entire site.
          Michael de Raadt made changes -
          Link This issue has been marked as being related by MDL-31741 [ MDL-31741 ]
          Michael de Raadt made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Priority Minor [ 4 ] Major [ 3 ]
          Labels netspot partner triaged
          Assignee moodle.com [ moodle.com ] Adrian Greeve [ abgreeve ]
          Affects Version/s 2.3.3 [ 12373 ]
          Michael de Raadt made changes -
          Link This issue is duplicated by MDL-36649 [ MDL-36649 ]
          Adrian Greeve made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Fix Version/s STABLE Sprint 28 Alpha [ 12450 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Adrian Greeve made changes -
          Fix Version/s STABLE Sprint 28 Omega [ 12451 ]
          Fix Version/s STABLE Sprint 28 Alpha [ 12450 ]
          Adrian Greeve made changes -
          Peer reviewer fred
          Testing Instructions # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          # Try deleting both blocks. *_Ensure that an additional message is displayed when deleting these types of blocks (e.g. You are about to delete a block that appears throughout the site. Are you sure you want to do this?)._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Pull Master Diff URL https://github.com/abgreeve/moodle/compare/moodle:master...wip-MDL-30669-master
          Pull Master Branch wip-MDL-30669-master
          Pull from Repository git://github.com/abgreeve/moodle.git
          Tim Hunt made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Peer reviewer fred timhunt
          Tim Hunt made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Adrian Greeve made changes -
          Fix Version/s STABLE Sprint 29 Omega [ 12551 ]
          Fix Version/s STABLE Sprint 28 Omega [ 12451 ]
          Adrian Greeve made changes -
          Testing Instructions # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          # Try deleting both blocks. *_Ensure that an additional message is displayed when deleting these types of blocks (e.g. You are about to delete a block that appears throughout the site. Are you sure you want to do this?)._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          # Try deleting both blocks. *_Ensure that an additional message is displayed when deleting these types of blocks (e.g. You are about to delete a block that appears everywhere below the following context X. Are you sure you want to do this?)._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          Adrian Greeve made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Adrian Greeve made changes -
          Testing Instructions # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          # Try deleting both blocks. *_Ensure that an additional message is displayed when deleting these types of blocks (e.g. You are about to delete a block that appears everywhere below the following context X. Are you sure you want to do this?)._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          # Try deleting both blocks. *_Ensure that the following message is displayed when deleting these types of blocks (You are about to delete a block that appears elsewhere... )._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          Michael de Raadt made changes -
          Fix Version/s STABLE Sprint 30 Alpha [ 12552 ]
          Fix Version/s STABLE Sprint 29 Omega [ 12551 ]
          Adrian Greeve made changes -
          Fix Version/s STABLE Sprint 30 Omega [ 12553 ]
          Fix Version/s STABLE Sprint 30 Alpha [ 12552 ]
          Adrian Greeve made changes -
          Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Eloy Lafuente (stronk7) made changes -
          Labels netspot partner triaged netspot partner triaged ui_change
          Adrian Greeve made changes -
          Testing Instructions # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          # Try deleting both blocks. *_Ensure that the following message is displayed when deleting these types of blocks (You are about to delete a block that appears elsewhere... )._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          # Create a site wide block.
          # Set page contexts to 'Display throughout the entire site'.
          #* *_Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the following: ('System','Any page')._*
          # Create another block on the front page and set the page context to 'Display on the front page and any pages added to the front page'.
          #* *_Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Front page','Display on the front page and any pages added to the front page')._*
          # Enter a course and create a course wide block.
          # Set Display on page types to 'Any page'.
          #* *_Delete this block and check that the delete message contains information about the original location and the display on page types. Check that the information regarding the block location and page types are the same as what you configured ('Course:XXXX','Any page')._*
          # Try deleting a block in an activity. *_Check that no additional error message is displayed._*
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.4.1 [ 12461 ]
          Affects Version/s 2.5 [ 12452 ]
          Fix Version/s 2.3.5 [ 12558 ]
          Fix Version/s 2.4.2 [ 12559 ]
          David Monllaó made changes -
          Tester fred
          Frédéric Massart made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Frédéric Massart made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 28/Feb/13
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s STABLE Sprint 30 Omega [ 12553 ]

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: