Moodle
  1. Moodle
  2. MDL-30673

loginpasswordautocomplete problems with some browsers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.0.7, 2.1.4, 2.2.1
    • Component/s: Authentication
    • Labels:
    • Rank:
      33492

      Description

      MDL-30336 introduced one new setting (loginpasswordautocomplete), to control when the password autofill feature from the browser should be allowed in the login form.

      And testing failed with:

      Rajesh Taneja added a comment - 09/Dec/11 3:24 AM

      Sorry Guys,
      It fails on IE (ie8) and opera (11.51).

      On ie8:
      Password is populated no matter what configuration is set on moodle site

      On Opera:
      It requires hitting key icon to update password. Not sure if we can get around this.

      So this is one followup of the original issue, that is blocking the upstream process right now, please address it ASAP (if something can be done).

      Also, perhaps, it would be a good momment to verify how passwords are behaving in other areas of Moodle (course passwords, group passwords....). Feel free to create separate issue for that, but I bet there is some work to do in those areas too.

      Ciao

        Activity

        Hide
        Petr Škoda added a comment -

        I had similar problem in MDL-29917, I suppose the solution will be the same - that is add autocomplete off attribute to the login form too.

        testing...

        Show
        Petr Škoda added a comment - I had similar problem in MDL-29917, I suppose the solution will be the same - that is add autocomplete off attribute to the login form too. testing...
        Hide
        Petr Škoda added a comment -

        To integrators: please cherry pick to 2.x stable branches

        To testers: Opera is silly, I did not find a way to disable the form saving and key icon, at least it does not autofill the forms...

        Show
        Petr Škoda added a comment - To integrators: please cherry pick to 2.x stable branches To testers: Opera is silly, I did not find a way to disable the form saving and key icon, at least it does not autofill the forms...
        Hide
        Sam Hemelryk added a comment -

        Integrated thanks Petr, there was a conflict in 20 for this issue as well, however it was just the lang string so I cleaned it up during integration.
        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Integrated thanks Petr, there was a conflict in 20 for this issue as well, however it was just the lang string so I cleaned it up during integration. Cheers Sam
        Hide
        Adrian Greeve added a comment -

        The only issue that I could find is if the user is using firefox and already has the password saved for the website. Firefox will still auto-complete the password.
        Tested with firefox, IE, Opera and chrome.
        Test passed.

        Show
        Adrian Greeve added a comment - The only issue that I could find is if the user is using firefox and already has the password saved for the website. Firefox will still auto-complete the password. Tested with firefox, IE, Opera and chrome. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The git and cvs repositories are happy receiving your very first contribution to Moodle for 2012. Happy new year! Closing, ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: