[MDL-30677] Number of attempts counted wrongly under some combinations - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-30677~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-30677
Testing Instructions:

Hide

1. Create a course with two groups. And one student to both groups.

2. Create a quiz set to separate groups mode.

3. As that student, make one quiz attempts.

4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)

Show
1. Create a course with two groups. And one student to both groups. 2. Create a quiz set to separate groups mode. 3. As that student, make one quiz attempts. 4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)

Testing ~~MDL-27314~~ I detected that:

1 course, with one teacher into 2 groups "GA" and "GB", set to separate groups and teacher "view all groups" cap prevented.
1 attempt, by one student also member of "GA" and "GB".
The number of attempts in the quiz view page shows: "1 (2 from your groups)"

So it seems that the attempt is being counted as many times as the teacher "share" groups with the student.

Surely a border-case, but annoying.

From Tim, @ HQ chat:

The bug will be in the SQL in quiz_num_attempt_summary

Ciao

Testing discovered

MDL-27314 Not possible to delete or regrade selected quiz attempts in separate groups mode

Participants:: Adrian Greeve, Eloy Lafuente (stronk7), Sam Hemelryk, Tim Hunt