Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30677

Number of attempts counted wrongly under some combinations

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.0.7, 2.1.4, 2.2.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a course with two groups. And one student to both groups.

      2. Create a quiz set to separate groups mode.

      3. As that student, make one quiz attempts.

      4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)

      Show
      1. Create a course with two groups. And one student to both groups. 2. Create a quiz set to separate groups mode. 3. As that student, make one quiz attempts. 4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Testing MDL-27314 I detected that:

      • 1 course, with one teacher into 2 groups "GA" and "GB", set to separate groups and teacher "view all groups" cap prevented.
      • 1 attempt, by one student also member of "GA" and "GB".
      • The number of attempts in the quiz view page shows: "1 (2 from your groups)"

      So it seems that the attempt is being counted as many times as the teacher "share" groups with the student.

      Surely a border-case, but annoying.

      From Tim, @ HQ chat:

      The bug will be in the SQL in quiz_num_attempt_summary

      Ciao

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Tim - integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Tim - integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested. Everything working as expected.

            Show
            abgreeve Adrian Greeve added a comment - Tested. Everything working as expected.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

            Now... disconnect, relax and enjoy the next days, yay!

            Closing...ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/12