Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30677

Number of attempts counted wrongly under some combinations

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.6, 2.1.3, 2.2, 2.3
    • Fix Version/s: 2.0.7, 2.1.4, 2.2.1
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a course with two groups. And one student to both groups.

      2. Create a quiz set to separate groups mode.

      3. As that student, make one quiz attempts.

      4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)

      Show
      1. Create a course with two groups. And one student to both groups. 2. Create a quiz set to separate groups mode. 3. As that student, make one quiz attempts. 4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Testing MDL-27314 I detected that:

      • 1 course, with one teacher into 2 groups "GA" and "GB", set to separate groups and teacher "view all groups" cap prevented.
      • 1 attempt, by one student also member of "GA" and "GB".
      • The number of attempts in the quiz view page shows: "1 (2 from your groups)"

      So it seems that the attempt is being counted as many times as the teacher "share" groups with the student.

      Surely a border-case, but annoying.

      From Tim, @ HQ chat:

      The bug will be in the SQL in quiz_num_attempt_summary

      Ciao

        Gliffy Diagrams

          Issue Links

            Activity

            stronk7 Eloy Lafuente (stronk7) created issue -
            stronk7 Eloy Lafuente (stronk7) made changes -
            Field Original Value New Value
            Link This issue discovered while testing MDL-27314 [ MDL-27314 ]
            timhunt Tim Hunt made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/timhunt/moodle/compare/master...MDL-30677
            Pull Master Branch MDL-30677
            Pull 2.0 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_20_STABLE...MDL-30677_20
            Pull from Repository git://github.com/timhunt/moodle.git
            Pull 2.0 Branch MDL-30677_20
            Fix Version/s 2.0.7 [ 11451 ]
            Fix Version/s 2.1.4 [ 11452 ]
            Fix Version/s 2.2.1 [ 11456 ]
            Fix Version/s 2.3 [ 10657 ]
            Testing Instructions 1. Create a course with two groups. And one student to both groups.

            2. Create a quiz set to separate groups mode.

            3. As that student, make one quiz attempts.

            4. As admin (or any user with access all groups) go to the quiz view page. Make sure it says "1 attempts (1 from your groups)". (Not 2 from your groups.)
            Pull 2.1 Branch MDL-30677_21
            Pull 2.2 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_22_STABLE...MDL-30677_22
            Pull 2.1 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-30677_21
            Pull 2.2 Branch MDL-30677_22
            salvetore Michael de Raadt made changes -
            Labels triaged
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.3 [ 10657 ]
            abgreeve Adrian Greeve made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester abgreeve
            abgreeve Adrian Greeve made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 23/Dec/11

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/12