Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.2, 2.2
-
Fix Version/s: 2.3
-
Component/s: Forum
-
Labels:
-
Environment:Moodle: Windows Server 2008 R2; MySQL DB;
Mailserver: Linux SuSE postfix, mails dropped and picked up by POP3
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-30698_multiple_emails -
Pull Master Diff URL:
Description
I don't know if this is a mailserver-specific problem - so I've set it as an "Improvement".
If a new forum post is written, every subscriber gets an e-mail. If more than one person has subscribed to the forum, only one of all e-mails arrive. The problem was, that the mailserver identified them as "duplicate" because of the same "message-ID". So only the first mail was delivered. Looking into the code, this was clear....:
../mod/forum/lib.php line 602 (v2.1.2): 'Message-ID: <moodlepost'.$post->id.'@'.$hostname.'>',
The message-ID consists of the "post-ID"...
To have individual message-IDs, I just put the "userto-ID" into it as well: 'Message-ID: <moodlepost'.$post->id.$userto->id.'@'.$hostname.'>',
Now it works, every subscriber gets an e-mail.
I wonder if the behaviour of our mailserver is normal, but maybe this hint can help others too...
Attachments
Issue Links
- caused a regression
-
MDL-34153 Message-ID generated in forum posts are not valid RFC-2822 -> marked as SPAM
-
- Closed
-
- Discovered while testing
-
MDL-31739 forum_get_email_message_id() is missing a doc block
-
- Closed
-
- has a QA test
-
MDL-31707 Add environmental check to 2.3 about the hash extension installed.
-
- Closed
-