Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30370 Meta: Oracle SQL issues
  3. MDL-30700

Error sorting assignment submissions by comment (in Oracle)

    XMLWordPrintable

    Details

    • Database:
      Oracle
    • Testing Instructions:
      Hide

      Test pre-requisites - Oracle on Moodle 2.2, Moodle 2.3 and Moodle 2.5-dev

      1. Create an advanced uploading of files (Assignment 2.2) in a course with some students
      2. Click the "No attempts have been made on this assignment" link
      3. Grade the first student and add a feedback comment
      4. Grade the second student and add a feedback comment
      5. Click on the column header "Comment" to sort by the feedback comments
      6. Verify the column is sorted correctly by the feedback comments
      7. Click on the "Update" link for one of the submissions to update the feedback/grades
      8. Verify you see the grading page for that submission and not an error.
      Show
      Test pre-requisites - Oracle on Moodle 2.2, Moodle 2.3 and Moodle 2.5-dev Create an advanced uploading of files (Assignment 2.2) in a course with some students Click the "No attempts have been made on this assignment" link Grade the first student and add a feedback comment Grade the second student and add a feedback comment Click on the column header "Comment" to sort by the feedback comments Verify the column is sorted correctly by the feedback comments Click on the "Update" link for one of the submissions to update the feedback/grades Verify you see the grading page for that submission and not an error.
    • Workaround:
      Hide

      As far as clob datatype isn't allowed in an order by sentence, I suppose that those datatype columns should be casted in allowed datatypes somehow.

      Show
      As far as clob datatype isn't allowed in an order by sentence, I suppose that those datatype columns should be casted in allowed datatypes somehow.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-30700-master

      Description

      When sorting the assignment submissions by comment in Oracle it crashes with ORA-00932 inconsistent datatypes: expected - got clob

      * line 394 of \lib\dml\moodle_database.php: dml_read_exception thrown
      * line 268 of \lib\dml\oci_native_moodle_database.php: call to moodle_database->query_end()
      * line 1093 of \lib\dml\oci_native_moodle_database.php: call to oci_native_moodle_database->query_end()
      * line 1325 of \mod\assignment\lib.php: call to oci_native_moodle_database->get_records_sql()
      * line 649 of \mod\assignment\lib.php: call to assignment_base->display_submissions()
      * line 369 of \mod\assignment\type\upload\assignment.class.php: call to assignment_base->submissions()
      * line 57 of \mod\assignment\submissions.php: call to assignment_upload->submissions()

      This is because the comment column (mdl_assignment_submissions.submissioncomment) datatype is CLOB, and (at least in Oracle) that kind of columns aren't allowed in the order by sentence

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              izendegi Iñigo Zendegi
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Jan/13