Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      Create a forum and a discussion within it if you don't have one already.

      View a discussion. Note just the forum but a discussion. It will be discuss.php, not view.php.

      Log in as admin or teacher if you havent already. View the course live logs. My courses > course name > reports > live logs.

      Look for a log entry called "forum view discussion". Click the link to the forum discussion. Its in the action column. The correct forum discussion should open.

      Show
      Create a forum and a discussion within it if you don't have one already. View a discussion. Note just the forum but a discussion. It will be discuss.php, not view.php. Log in as admin or teacher if you havent already. View the course live logs. My courses > course name > reports > live logs. Look for a log entry called "forum view discussion". Click the link to the forum discussion. Its in the action column. The correct forum discussion should open.
    • Workaround:
      Hide

      in mod/forum/discuss.php:
      replace:

      add_to_log($course->id, 'forum', 'view discussion', $PAGE->url->out(false), $discussion->id, $cm->id);

      with:

      add_to_log($course->id, 'forum', 'view discussion', "discuss.php?d=$discussion->id", $discussion->id, $cm->id);

      Show
      in mod/forum/discuss.php: replace: add_to_log($course->id, 'forum', 'view discussion', $PAGE->url->out(false), $discussion->id, $cm->id); with: add_to_log($course->id, 'forum', 'view discussion', "discuss.php?d=$discussion->id", $discussion->id, $cm->id);
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-30707_forum_log

      Description

      The log when you access to a discussion in the forum in not saved in the right way, the url is saved with full path, but only discuss.php?id=xx has to be saved. So when you access to registers the url is bad generated.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for reporting that and providing a solution.

              Show
              salvetore Michael de Raadt added a comment - Thanks for reporting that and providing a solution.
              Hide
              andyjdavis Andrew Davis added a comment -

              That seems to work as expected. Thank you rodrigo

              Show
              andyjdavis Andrew Davis added a comment - That seems to work as expected. Thank you rodrigo
              Hide
              andyjdavis Andrew Davis added a comment -

              Adding testing instructions.

              Show
              andyjdavis Andrew Davis added a comment - Adding testing instructions.
              Hide
              abgreeve Adrian Greeve added a comment -

              Looks good. I tested it out and it works.
              Thanks Andrew.

              Show
              abgreeve Adrian Greeve added a comment - Looks good. I tested it out and it works. Thanks Andrew.
              Hide
              andyjdavis Andrew Davis added a comment -

              Adding various branches and submitting for integration

              Show
              andyjdavis Andrew Davis added a comment - Adding various branches and submitting for integration
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              nebgor Aparup Banerjee added a comment -

              thanks, thats been integrated into 21, 22 and master for testing.

              Show
              nebgor Aparup Banerjee added a comment - thanks, thats been integrated into 21, 22 and master for testing.
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              This is working great!
              passing
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - This is working great! passing Thanks
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories.

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories. Closing, ciao

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Mar/12