Moodle
  1. Moodle
  2. MDL-30712

Course completion export files do not contain header row

    Details

    • Workaround:
      Hide

      The only work around is to manually insert the row and complete the cells- NOT.HAPPY.JAN!

      Show
      The only work around is to manually insert the row and complete the cells- NOT.HAPPY.JAN!
    • Affected Branches:
      MOODLE_21_STABLE

      Description

      When you export an Activity Completion report the resultant file e.g. .CSV exports beautifully but does not contain the header row which makes the report pretty useless.
      This is a fantastic feature that I'm madly spruiking to our teachers but it's half pregnant if you cannot view the activities to which the report refers.

      PLEASE, PLEASE fix this obvious oversight and blight on a fantastic improvement

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Marshall added a comment -

            Just to clarify, are you referring to 'course completion' (as subject) or 'activity completion' (as text)? There are two different reports.

            Show
            Sam Marshall added a comment - Just to clarify, are you referring to 'course completion' (as subject) or 'activity completion' (as text)? There are two different reports.
            Hide
            Sam Marshall added a comment -

            Thanks. Damn, that makes it my problem...

            Show
            Sam Marshall added a comment - Thanks. Damn, that makes it my problem...
            Hide
            Geoff Young added a comment -

            Sorry for the mix up but this is too good a feature to not have it 100% functional would be a shame

            Show
            Geoff Young added a comment - Sorry for the mix up but this is too good a feature to not have it 100% functional would be a shame
            Hide
            Sam Marshall added a comment -

            Sorry, but you are wrong! It's course completion, not activity completion. (As in - the name you clicked on to get the report was 'Course completion' and the filename is course/report/completion/index.php - for activity completion it is 'Activity completion' and the filename is course/report/progress/index.php.)

            The reason I know this is that I looked in the code. The activity completion report contains code that displays the headers, even in the 2.1 version, whereas the course completion report includes the following code:

            } else {
                // The CSV file does not contain any headers
            }
            

            to which the obvious retort is WELL WHY NOT?!

            (Also I did a quick export from an activity completion report on our 2.1-based system and it includes headers in the csv file.)

            Anyway, reassigning to 'course completion' (it's somebody else) and changing subject etc.

            Show
            Sam Marshall added a comment - Sorry, but you are wrong! It's course completion, not activity completion. (As in - the name you clicked on to get the report was 'Course completion' and the filename is course/report/completion/index.php - for activity completion it is 'Activity completion' and the filename is course/report/progress/index.php.) The reason I know this is that I looked in the code. The activity completion report contains code that displays the headers, even in the 2.1 version, whereas the course completion report includes the following code: } else { // The CSV file does not contain any headers } to which the obvious retort is WELL WHY NOT?! (Also I did a quick export from an activity completion report on our 2.1-based system and it includes headers in the csv file.) Anyway, reassigning to 'course completion' (it's somebody else) and changing subject etc.
            Hide
            Geoff Young added a comment -

            Sorry Sam I was correct the first time. Many apologies- busy day.

            Show
            Geoff Young added a comment - Sorry Sam I was correct the first time. Many apologies- busy day.
            Hide
            Michael de Raadt added a comment -

            Glad we got that sorted out.

            Thanks for reporting that, Geoff, and thanks for looking at it, Sam.

            Show
            Michael de Raadt added a comment - Glad we got that sorted out. Thanks for reporting that, Geoff, and thanks for looking at it, Sam.
            Hide
            Geoff Young added a comment -

            So I assume Michael that you will fix the problem? If this is the case what is the resolve timeline?

            Thanks in advance too if it's you that's looking at it.
            GY

            Show
            Geoff Young added a comment - So I assume Michael that you will fix the problem? If this is the case what is the resolve timeline? Thanks in advance too if it's you that's looking at it. GY
            Hide
            Peter Bersbach added a comment -

            I see that this problem has not been resolved yet I just ran into it. We just upgraded to Moodle 2.2.2+ (build: 20120323) What is the time line for the solution as this report is useless until it has the header?

            Show
            Peter Bersbach added a comment - I see that this problem has not been resolved yet I just ran into it. We just upgraded to Moodle 2.2.2+ (build: 20120323) What is the time line for the solution as this report is useless until it has the header?
            Hide
            Jason Ilicic added a comment -

            I've added the headers myself for this one, so figured I'd share the code that I used. I've tested this in 2.1 and it works, but I haven't tested the 2.2 patch (it seemed to apply cleanly enough).

            2.1: https://github.com/jasonilicic/moodle/commit/dab6f1e2213b50abc233dea68b571f228793456e
            2.2: https://github.com/jasonilicic/moodle/commit/3b38974812c479b725cc10d182e6fba9178ac627

            Enjoy.

            Show
            Jason Ilicic added a comment - I've added the headers myself for this one, so figured I'd share the code that I used. I've tested this in 2.1 and it works, but I haven't tested the 2.2 patch (it seemed to apply cleanly enough). 2.1: https://github.com/jasonilicic/moodle/commit/dab6f1e2213b50abc233dea68b571f228793456e 2.2: https://github.com/jasonilicic/moodle/commit/3b38974812c479b725cc10d182e6fba9178ac627 Enjoy.

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: