Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      run the following command on each patched branch and make sure there is no output:

      cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin
      

      note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.

      Show
      run the following command on each patched branch and make sure there is no output: cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-30723_fixing_several_english_typos
    • Rank:
      33599

      Description

      [err_networkingoff_help,portfolio_mahara] "pugin" => "plugin".
      [tiierror1024,plagiarism_turnitin] "legitamate" => "legitimate".
      [configlockframe,hotpot] "navagation" => "navigation"

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting that.

          Koen, do you think you could make these amendments?

          Show
          Michael de Raadt added a comment - Thanks for reporting that. Koen, do you think you could make these amendments?
          Hide
          Helen Foster added a comment -

          Assigning to Gerry as suggested by Michael, since Koen is not responsible for en lang strings.

          As hotpot is now a contributed module, it would be helpful if the typo [configlockframe,hotpot] "navagation" => "navigation" was reported as a non-core contributed modules bug.

          Show
          Helen Foster added a comment - Assigning to Gerry as suggested by Michael, since Koen is not responsible for en lang strings. As hotpot is now a contributed module, it would be helpful if the typo [configlockframe,hotpot] "navagation" => "navigation" was reported as a non-core contributed modules bug.
          Hide
          Gerard Caulfield added a comment -

          [printintroexplain,mod_resource] "bellow" => "below" is fixed by MDL-29153 so I'm amending this description

          Show
          Gerard Caulfield added a comment - [printintroexplain,mod_resource] "bellow" => "below" is fixed by MDL-29153 so I'm amending this description
          Hide
          Gerard Caulfield added a comment -

          I've supplied a patch for "pugin". But I could not find any instances of "legitamate" or "navagation". Where would be the appropriate place to report these issues... if they still exist?

          Show
          Gerard Caulfield added a comment - I've supplied a patch for "pugin". But I could not find any instances of "legitamate" or "navagation". Where would be the appropriate place to report these issues... if they still exist?
          Hide
          David Mudrak added a comment -

          As Helen says, both mod_hotpot and plagiarism_turnitin typos should be reported in contributed plugins as these two are not included in the core.

          Show
          David Mudrak added a comment - As Helen says, both mod_hotpot and plagiarism_turnitin typos should be reported in contributed plugins as these two are not included in the core.
          Hide
          Gerard Caulfield added a comment -

          I see, thanks again David. I'll do so.

          Show
          Gerard Caulfield added a comment - I see, thanks again David. I'll do so.
          Hide
          Gerard Caulfield added a comment -

          Issue added to contrib.

          Show
          Gerard Caulfield added a comment - Issue added to contrib.
          Hide
          Ankit Agarwal added a comment -

          Hi Gerry,
          This looks great.
          +1 to integrate.
          Don't forget to update testing instructions
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Gerry, This looks great. +1 to integrate. Don't forget to update testing instructions Thanks
          Hide
          Gerard Caulfield added a comment -

          Thanks Ankit, I'll make sure to add the instructions

          Show
          Gerard Caulfield added a comment - Thanks Ankit, I'll make sure to add the instructions
          Hide
          Helen Foster added a comment -

          Re. testing, how about going to the place in Moodle where the lang string appears and checking that the updated string is displayed?

          Show
          Helen Foster added a comment - Re. testing, how about going to the place in Moodle where the lang string appears and checking that the updated string is displayed?
          Hide
          Gerard Caulfield added a comment -

          Sure thing Helen. Depending on how integration is done this may be redundant, but it can't hurt.

          Show
          Gerard Caulfield added a comment - Sure thing Helen. Depending on how integration is done this may be redundant, but it can't hurt.
          Hide
          Sam Hemelryk added a comment -

          Thanks Gerry, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Gerry, this has been integrated now
          Hide
          Glenn Ansley added a comment -

          Tests passed. I confirmed it returned a line in current versions of branches and in 20 version of integrations. master, 22, and 21 branches of integrations find no instance of pugin in that file though. Looks good.

          Show
          Glenn Ansley added a comment - Tests passed. I confirmed it returned a line in current versions of branches and in 20 version of integrations. master, 22, and 21 branches of integrations find no instance of pugin in that file though. Looks good.
          Hide
          Gerard Caulfield added a comment -

          Thanks Sam, Glenn and everybody else.

          Show
          Gerard Caulfield added a comment - Thanks Sam, Glenn and everybody else.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

          Closing as fixed, heading to zzzZZZzzz, niao

          Show
          Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: