Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      run the following command on each patched branch and make sure there is no output:

      cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin

      note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.

      Show
      run the following command on each patched branch and make sure there is no output: cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-30723_fixing_several_english_typos

      Description

      [err_networkingoff_help,portfolio_mahara] "pugin" => "plugin".
      [tiierror1024,plagiarism_turnitin] "legitamate" => "legitimate".
      [configlockframe,hotpot] "navagation" => "navigation"

        Gliffy Diagrams

          Issue Links

            Activity

            laaneoks Erkki Laaneoks created issue -
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting that.

            Koen, do you think you could make these amendments?

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting that. Koen, do you think you could make these amendments?
            salvetore Michael de Raadt made changes -
            Field Original Value New Value
            Fix Version/s STABLE backlog [ 10463 ]
            Labels patch triaged
            Assignee moodle.com [ moodle.com ] Koen Roggemans [ koen ]
            Difficulty Easy [ 10023 ]
            tsala Helen Foster made changes -
            Parent MDL-30759 [ 49752 ]
            Issue Type Bug [ 1 ] Sub-task [ 5 ]
            Hide
            tsala Helen Foster added a comment -

            Assigning to Gerry as suggested by Michael, since Koen is not responsible for en lang strings.

            As hotpot is now a contributed module, it would be helpful if the typo [configlockframe,hotpot] "navagation" => "navigation" was reported as a non-core contributed modules bug.

            Show
            tsala Helen Foster added a comment - Assigning to Gerry as suggested by Michael, since Koen is not responsible for en lang strings. As hotpot is now a contributed module, it would be helpful if the typo [configlockframe,hotpot] "navagation" => "navigation" was reported as a non-core contributed modules bug.
            tsala Helen Foster made changes -
            Assignee Koen Roggemans [ koen ] Gerard Caulfield [ gerry ]
            tsala Helen Foster made changes -
            Parent Issue MDL-30759 [ MDL-30759 ] MDL-29160 [ MDL-29160 ]
            Hide
            gerry Gerard Caulfield added a comment -

            [printintroexplain,mod_resource] "bellow" => "below" is fixed by MDL-29153 so I'm amending this description

            Show
            gerry Gerard Caulfield added a comment - [printintroexplain,mod_resource] "bellow" => "below" is fixed by MDL-29153 so I'm amending this description
            gerry Gerard Caulfield made changes -
            Description [err_networkingoff_help,portfolio_mahara] "pugin" => "plugin".
            [printintroexplain,mod_resource] "bellow" => "below".
            [tiierror1024,plagiarism_turnitin] "legitamate" => "legitimate".
            [configlockframe,hotpot] "navagation" => "navigation"
            [err_networkingoff_help,portfolio_mahara] "pugin" => "plugin".
            [tiierror1024,plagiarism_turnitin] "legitamate" => "legitimate".
            [configlockframe,hotpot] "navagation" => "navigation"
            Hide
            gerry Gerard Caulfield added a comment -

            I've supplied a patch for "pugin". But I could not find any instances of "legitamate" or "navagation". Where would be the appropriate place to report these issues... if they still exist?

            Show
            gerry Gerard Caulfield added a comment - I've supplied a patch for "pugin". But I could not find any instances of "legitamate" or "navagation". Where would be the appropriate place to report these issues... if they still exist?
            gerry Gerard Caulfield made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Hide
            mudrd8mz David Mudrak added a comment -

            As Helen says, both mod_hotpot and plagiarism_turnitin typos should be reported in contributed plugins as these two are not included in the core.

            Show
            mudrd8mz David Mudrak added a comment - As Helen says, both mod_hotpot and plagiarism_turnitin typos should be reported in contributed plugins as these two are not included in the core.
            Hide
            gerry Gerard Caulfield added a comment -

            I see, thanks again David. I'll do so.

            Show
            gerry Gerard Caulfield added a comment - I see, thanks again David. I'll do so.
            gerry Gerard Caulfield made changes -
            Link This issue has a non-specific relationship to CONTRIB-3457 [ CONTRIB-3457 ]
            Hide
            gerry Gerard Caulfield added a comment -

            Issue added to contrib.

            Show
            gerry Gerard Caulfield added a comment - Issue added to contrib.
            ankit_frenz Ankit Agarwal made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            Peer reviewer ankit_frenz
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Gerry,
            This looks great.
            +1 to integrate.
            Don't forget to update testing instructions
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Gerry, This looks great. +1 to integrate. Don't forget to update testing instructions Thanks
            ankit_frenz Ankit Agarwal made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            Hide
            gerry Gerard Caulfield added a comment -

            Thanks Ankit, I'll make sure to add the instructions

            Show
            gerry Gerard Caulfield added a comment - Thanks Ankit, I'll make sure to add the instructions
            gerry Gerard Caulfield made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            gerry Gerard Caulfield made changes -
            Testing Instructions No testing necessary
            Hide
            tsala Helen Foster added a comment -

            Re. testing, how about going to the place in Moodle where the lang string appears and checking that the updated string is displayed?

            Show
            tsala Helen Foster added a comment - Re. testing, how about going to the place in Moodle where the lang string appears and checking that the updated string is displayed?
            Hide
            gerry Gerard Caulfield added a comment -

            Sure thing Helen. Depending on how integration is done this may be redundant, but it can't hurt.

            Show
            gerry Gerard Caulfield added a comment - Sure thing Helen. Depending on how integration is done this may be redundant, but it can't hurt.
            gerry Gerard Caulfield made changes -
            Testing Instructions No testing necessary run the following command on each patched branch and make sure there is no output:
            {code}
            cat portfolio/mahara/lang/en/portfolio_mahara.php | grep pugin
            {code}

            note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "pugin" string.
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Gerry, this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Gerry, this has been integrated now
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.1.5 [ 11553 ]
            Fix Version/s 2.2.2 [ 11552 ]
            Fix Version/s STABLE backlog [ 10463 ]
            blepoxp Glenn Ansley made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester blepoxp
            Hide
            blepoxp Glenn Ansley added a comment -

            Tests passed. I confirmed it returned a line in current versions of branches and in 20 version of integrations. master, 22, and 21 branches of integrations find no instance of pugin in that file though. Looks good.

            Show
            blepoxp Glenn Ansley added a comment - Tests passed. I confirmed it returned a line in current versions of branches and in 20 version of integrations. master, 22, and 21 branches of integrations find no instance of pugin in that file though. Looks good.
            blepoxp Glenn Ansley made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            gerry Gerard Caulfield added a comment -

            Thanks Sam, Glenn and everybody else.

            Show
            gerry Gerard Caulfield added a comment - Thanks Sam, Glenn and everybody else.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

            Closing as fixed, heading to zzzZZZzzz, niao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Integration date 17/Feb/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12