Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30724

assignment_count_real_submissions() assumes all rows with a positive timestamp are "real submissions" when this is not true for upload assignment types

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as Admin
      2. Create a new assignment of type "advanced file upload"
        1. Click "Upload file"
        2. Add some files
        3. "Save changes"
        4. Look at the links under "Settings > Assignment administration" and observe that there is one that reads "No attempts have been made on this assignment"
        5. Click "Send for marking"
        6. Click "Continue"
        7. Look at the links under "Settings > Assignment administration" and observe that there is one that reads "View 1 submitted assignments"
      3. Create a new assignment of type "simple file upload"
        1. Click "Upload a file"
        2. Click "Save changes" without adding any files
        3. Look at the links under "Settings > Assignment administration" and observe that there is one that reads "No attempts have been made on this assignment"
        4. Click "Upload a file" again
        5. Add a file
        6. Click "Save changes"
        7. Look at the links under "Settings > Assignment administration" and observe that there is one that reads "View 1 submitted assignments"
      Show
      Login as Admin Create a new assignment of type "advanced file upload" Click "Upload file" Add some files "Save changes" Look at the links under "Settings > Assignment administration" and observe that there is one that reads "No attempts have been made on this assignment" Click "Send for marking" Click "Continue" Look at the links under "Settings > Assignment administration" and observe that there is one that reads "View 1 submitted assignments" Create a new assignment of type "simple file upload" Click "Upload a file" Click "Save changes" without adding any files Look at the links under "Settings > Assignment administration" and observe that there is one that reads "No attempts have been made on this assignment" Click "Upload a file" again Add a file Click "Save changes" Look at the links under "Settings > Assignment administration" and observe that there is one that reads "View 1 submitted assignments"
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m_MDL-30724_count_real_submissions_eloy_suggests
    • Pull Master Diff URL:

      Description

      The Advanced uploading and single file upload assignments both will create an entry in the assignment_submissions table as placeholders. The assignment_count_real_submissions() function counts these as valid submissions when it should not.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31987 Always "No attempts" if disabled "Send for marking" button

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32207 assignment_count_real_submissions() for Advanced upload causes error

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33660 After upgraded to 2.2.3, view assignment get ORA-00932 "inconsistent datatypes: expected - got CLOB"

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30957 A misleading submitted date shows up on the student view for assignment before the submission takes place

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29400 Single file assignment displays 'File uploaded successfully' when no file uploaded

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              moodle.com moodle.com
              Reporter:
              gerry Gerard Caulfield
              Peer reviewer:
              Andrew Davis
              Integrator:
              Sam Hemelryk
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12