Details
-
Bug
-
Status: Closed
-
Critical
-
Resolution: Fixed
-
2.0.6, 2.1, 2.2
-
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
MOODLE_21_STABLE, MOODLE_22_STABLE
-
w23_
MDL-30725_m23_backuptrash -
Description
The current backup code copies the temporary zip file to the file pool, and depending on external storage settings will then copy to this location and then potentially delete the file pool copy.
Deleting the filepool backup copy means this is sent into trashdir, which on large sites where many backups run at once can cause a huge amount of additional disk usage before the trashdir is cleared. Additionally, the additional disk operations cause the whole backup process to take much longer than it should as there is twice the work involved.
This should be changed, so that in the case where automated course backups should only be put in an external storage location they are put there directly instead of first running past the filepool and fillingtrashdir.
Somewhat ugly patch for this incoming - there might be a better way to handle this?
Attachments
Issue Links
- Discovered while testing
-
MDL-33583 keep all automated backups deletes all automated backups instead
-
- Closed
-
- has been marked as being related by
-
MDL-33813 backup_auto_storage not being honoured
-
- Closed
-
-
MDL-53747 Automated backups on external disks are moved into trashdir folder for another 24 hours.
-
- Closed
-
- is duplicated by
-
MDL-32100 Removal of backup files not working for automate backups
-
- Closed
-