Moodle
  1. Moodle
  2. MDL-30734

When all questions in a quiz are 'Not answered', regrading changes sumgrades from 0.00 -> NULL

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Questions, Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. As teacher, create a quiz.
      2. As student, start an attempt, click 'Finish attempt...', and then 'Submit all and finish' without entering anything.
      3. As teacher, go to Quiz > Reports > Grades, and verify that the mark for each question is shown as '-', and the attempt total is shown as '0.00' (number of decimal places depends on quiz settings.
      4. Click the regrade all button.
      5. Verify that the attempt total stays as 0.00, and does not change to 'Not yet graded'

      There is an alternative to step 4:

      4'. Go to the Edit quiz page, change the Grade for a question, and click save changes.


      A. Also, create a quiz with some Essay questions.
      B. As a student make several attempts, leaving some (or all) questions blank, and other attempts were you answer some or all questions.
      C. As teacher, manually grade some of the questions.
      D. Then do the same thing as in 4. or 4'.
      E. Make sure that the total grade for the quiz attempt is only computed if all the questions in the quiz attempt are graded or gave up. Otherwise the quiz total should be 'Not yet graded'.

      Show
      1. As teacher, create a quiz. 2. As student, start an attempt, click 'Finish attempt...', and then 'Submit all and finish' without entering anything. 3. As teacher, go to Quiz > Reports > Grades, and verify that the mark for each question is shown as '-', and the attempt total is shown as '0.00' (number of decimal places depends on quiz settings. 4. Click the regrade all button. 5. Verify that the attempt total stays as 0.00, and does not change to 'Not yet graded' There is an alternative to step 4: 4'. Go to the Edit quiz page, change the Grade for a question, and click save changes. A. Also, create a quiz with some Essay questions. B. As a student make several attempts, leaving some (or all) questions blank, and other attempts were you answer some or all questions. C. As teacher, manually grade some of the questions. D. Then do the same thing as in 4. or 4'. E. Make sure that the total grade for the quiz attempt is only computed if all the questions in the quiz attempt are graded or gave up. Otherwise the quiz total should be 'Not yet graded'.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      33612

      Description

      I am pretty sure that the bug is in sum_usage_marks_subquery, when all questions in the usage are in the 'gaveup' state.

        Activity

        Hide
        Sam Hemelryk added a comment -

        Thanks Tim - this has been integrated

        Show
        Sam Hemelryk added a comment - Thanks Tim - this has been integrated
        Hide
        Sam Hemelryk added a comment -

        Tested during integration review and passed.

        Show
        Sam Hemelryk added a comment - Tested during integration review and passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

        Now... disconnect, relax and enjoy the next days, yay!

        Closing...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: