Moodle
  1. Moodle
  2. MDL-30735

cron.php maintenancerun detection

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.1
    • Component/s: Administration
    • Labels:
    • Environment:
      LINUX WITH PHP 5.3.8
    • Database:
      Any
    • Testing Instructions:
      Hide

      1/ install moodle 2.2
      2/ run cron
      3/ verify cron warning disappeared from the notification page

      Show
      1/ install moodle 2.2 2/ run cron 3/ verify cron warning disappeared from the notification page
    • Workaround:
      Hide

      I have already identified the problem... It is in line 195 of the file moodle/admin/renderer.php... The parameter of "cron_overdue_warning" is incorrect... It would to be "$cronoverdue" instead the current "$errorsdisplayed". This change solves the problem.

      Show
      I have already identified the problem... It is in line 195 of the file moodle/admin/renderer.php... The parameter of "cron_overdue_warning" is incorrect... It would to be "$cronoverdue" instead the current "$errorsdisplayed". This change solves the problem.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w51_MDL-30735_m23_cron
    • Rank:
      33616

      Description

      The Admin Notification page does not seem to know about the last run of cron.php. The warning "The cron.php maintenance script has not been run for at least 24 hours" always appears. The script is running successfully...

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting that and providing a solution.

          Show
          Michael de Raadt added a comment - Thanks for reporting that and providing a solution.
          Hide
          Petr Škoda added a comment -

          Thanks a lot for the report and proposed solution!

          Show
          Petr Škoda added a comment - Thanks a lot for the report and proposed solution!
          Hide
          Aparup Banerjee added a comment -

          Thanks, this has integrated into 2.2.x and master.

          This has been tested too, so passing.

          Show
          Aparup Banerjee added a comment - Thanks, this has integrated into 2.2.x and master. This has been tested too, so passing.
          Hide
          Aparup Banerjee added a comment -

          works for me

          Show
          Aparup Banerjee added a comment - works for me
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: