Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.6
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      Prerequsites:

      1. You need a Microsoft Account
      2. Please add to your skydrive repository, at least:
        1. An image
        2. A video
        3. An audio file
        4. A word document
        5. Any other sort of file
        6. Please spread these files around folders
      1. Enable the skydrive repository plugin
      2. You will need to configure an API account with microsoft (http://docs.moodle.org/25/en/Skydrive_repository) and configure the api keys
      3. Go to my private files
      4. Browse the skydrive repository and ensure that you can view all your skydrive files
      5. VERFIY: that you can download each type of file
      6. VERIFY: that photos and videos show thumbnails of the file
      Show
      Prerequsites: You need a Microsoft Account Please add to your skydrive repository, at least: An image A video An audio file A word document Any other sort of file Please spread these files around folders Enable the skydrive repository plugin You will need to configure an API account with microsoft ( http://docs.moodle.org/25/en/Skydrive_repository ) and configure the api keys Go to my private files Browse the skydrive repository and ensure that you can view all your skydrive files VERFIY: that you can download each type of file VERIFY: that photos and videos show thumbnails of the file
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-30740-master
    • Rank:
      33639

      Description

      Microsoft skydrive seems to have an API and an iphone app now:

      http://msdn.microsoft.com/en-gb/windowslive/hh561740.aspx

      Looks like a plugin can be developed

        Issue Links

          Activity

          Dan Poltawski created issue -
          Dan Poltawski made changes -
          Field Original Value New Value
          Assignee Dongsheng Cai [ dongsheng ] Dan Poltawski [ poltawski ]
          Hide
          Michael de Raadt added a comment -

          Sounds good.

          Show
          Michael de Raadt added a comment - Sounds good.
          Michael de Raadt made changes -
          Fix Version/s DEV backlog [ 10464 ]
          Labels triaged
          Show
          Dan Poltawski added a comment - http://windowsteamblog.com/windows_live/b/windowslive/archive/2011/12/07/skydrive-apis-for-docs-and-photos-now-ready-to-cloud-enable-apps-on-windows-8-windows-phone-and-more.aspx
          Hide
          Jeffrey L. Jones added a comment -

          I'm REALLY hungry for this, since our entire state public education's (Ky) email system is hosted in Live (adults and students), and my district is one of dozens of state districts using Moodle. Got the following links from our statewide Microsoft rep this afternoon (he's in Seattle).

          http://msdn.microsoft.com/library/live/hh826521

          http://skydriveapiclient.codeplex.com/

          Hope this helps. I'd be workin' on this myself if I were a PHP guy...

          Show
          Jeffrey L. Jones added a comment - I'm REALLY hungry for this, since our entire state public education's (Ky) email system is hosted in Live (adults and students), and my district is one of dozens of state districts using Moodle. Got the following links from our statewide Microsoft rep this afternoon (he's in Seattle). http://msdn.microsoft.com/library/live/hh826521 http://skydriveapiclient.codeplex.com/ Hope this helps. I'd be workin' on this myself if I were a PHP guy...
          Hide
          Dan Poltawski added a comment -

          Hi Jeffery,

          Whilst I was working at LUNS a client from Universidad Teconológica de Chile (INACAP) funded us to produce this repository.

          The has been released open source code is available here:
          https://git.luns.net.uk/?p=moodle.git;a=shortlog;h=refs/heads/microsoft-skydrive

          It is my intention to integrate this into core however I have not yet been able to.
          cheers,
          dan

          Show
          Dan Poltawski added a comment - Hi Jeffery, Whilst I was working at LUNS a client from Universidad Teconológica de Chile (INACAP) funded us to produce this repository. The has been released open source code is available here: https://git.luns.net.uk/?p=moodle.git;a=shortlog;h=refs/heads/microsoft-skydrive It is my intention to integrate this into core however I have not yet been able to. cheers, dan
          Dan Poltawski made changes -
          Dan Poltawski made changes -
          Link This issue is blocked by MDL-29857 [ MDL-29857 ]
          Hide
          Dan Poltawski added a comment -

          Note I have created a branch based on this work on some promposed work to go into 2.3

          Show
          Dan Poltawski added a comment - Note I have created a branch based on this work on some promposed work to go into 2.3
          Hide
          Jeffrey L. Jones added a comment -

          Dan: After some initial excitement, I'm still a'begging. I'm afraid my initial test wasn't complete – I created the app with Microsoft, config'ed it in Moodle, then through the user interface, I could see my Skydrive files. When used, it seemed to download the file, and create the link. I am now in production on Moodle 2.2.3, and all that still works, but I've noticed that the created link is bogus – returns a 404/file not found error. Since we just finished a major upgrade from 1.9.18+ to 2.2.3, there are lots of variables here, but just wanted to put this out there. We ARE using Dropbox and Google Docs successfully, and locally-uploaded files work too.

          Windows Server 2008 R2/SP1, IIS 7.5, PHP 5.3, MySQL 5.1, Moodle 2.2.3.

          Show
          Jeffrey L. Jones added a comment - Dan: After some initial excitement, I'm still a'begging. I'm afraid my initial test wasn't complete – I created the app with Microsoft, config'ed it in Moodle, then through the user interface, I could see my Skydrive files. When used, it seemed to download the file, and create the link. I am now in production on Moodle 2.2.3, and all that still works, but I've noticed that the created link is bogus – returns a 404/file not found error. Since we just finished a major upgrade from 1.9.18+ to 2.2.3, there are lots of variables here, but just wanted to put this out there. We ARE using Dropbox and Google Docs successfully, and locally-uploaded files work too. Windows Server 2008 R2/SP1, IIS 7.5, PHP 5.3, MySQL 5.1, Moodle 2.2.3.
          Hide
          Dan Poltawski added a comment -

          Hi Jeffery,

          Some of the infrastructure is now in Moodle 2.3, so I will probably produce a plugin based on the above work to go into the modules and plugins DB (and later can be considered for inclusion to core).

          Show
          Dan Poltawski added a comment - Hi Jeffery, Some of the infrastructure is now in Moodle 2.3, so I will probably produce a plugin based on the above work to go into the modules and plugins DB (and later can be considered for inclusion to core).
          Hide
          Dan Poltawski added a comment -

          I probably wasn't clear enough. The branch attached to this issue contains the skydrive plugin for Moodle 2.3.

          It can be installed standalone and is a candidate for integrating into core. I have not done this for 2.3 as we are too close to release date but it should be easily installable from contrib.

          Show
          Dan Poltawski added a comment - I probably wasn't clear enough. The branch attached to this issue contains the skydrive plugin for Moodle 2.3. It can be installed standalone and is a candidate for integrating into core. I have not done this for 2.3 as we are too close to release date but it should be easily installable from contrib.
          Hide
          Dan Poltawski added a comment -

          Just a note that I have now released this plugin into Moodle plugins:
          http://moodle.org/plugins/view.php?plugin=repository_skydrive

          Show
          Dan Poltawski added a comment - Just a note that I have now released this plugin into Moodle plugins: http://moodle.org/plugins/view.php?plugin=repository_skydrive
          Hide
          Martin Dougiamas added a comment -

          Thanks Dan!

          +1 for core (have not reviewed the code yet)

          Show
          Martin Dougiamas added a comment - Thanks Dan! +1 for core (have not reviewed the code yet)
          Martin Dougiamas made changes -
          Fix Version/s 2.4 [ 12255 ]
          Fix Version/s DEV backlog [ 10464 ]
          Hide
          Dan Poltawski added a comment - - edited

          Before this goes into core I need to sort out the problem with folder navigation (it doesn't return path so you can't go down the navigation once you've navigated into a folder).

          Show
          Dan Poltawski added a comment - - edited Before this goes into core I need to sort out the problem with folder navigation (it doesn't return path so you can't go down the navigation once you've navigated into a folder).
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.4.1 [ 12461 ]
          Fix Version/s 2.4 [ 12255 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.4.2 [ 12559 ]
          Fix Version/s 2.4.1 [ 12461 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.4.3 [ 12569 ]
          Fix Version/s 2.4.2 [ 12559 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.4.4 [ 12575 ]
          Fix Version/s 2.4.3 [ 12569 ]
          Hide
          Richard Havinga added a comment -

          Is there any news on whether this plugin will go into core?

          Thanks

          Show
          Richard Havinga added a comment - Is there any news on whether this plugin will go into core? Thanks
          Hide
          Dan Poltawski added a comment -

          Hi Richard,

          I haven't got round to submitting it yet.

          Though it should be equally fine to use it from the plugins directory. Is there a reason that not being in core is causing a problem?

          Show
          Dan Poltawski added a comment - Hi Richard, I haven't got round to submitting it yet. Though it should be equally fine to use it from the plugins directory. Is there a reason that not being in core is causing a problem?
          Hide
          Richard Havinga added a comment -

          Hi Dan,

          Thanks for the update, that's great.No problem at all with using the plugin from the directory, just wondered about the future support of the plugin and you have answered my question.

          Thanks again

          Richard

          Show
          Richard Havinga added a comment - Hi Dan, Thanks for the update, that's great.No problem at all with using the plugin from the directory, just wondered about the future support of the plugin and you have answered my question. Thanks again Richard
          Hide
          Richard van Iwaarden added a comment -

          Hi Dan,

          Is the folder navigation problem you mentioned earlier solved now?

          Show
          Richard van Iwaarden added a comment - Hi Dan, Is the folder navigation problem you mentioned earlier solved now?
          Hide
          Dan Poltawski added a comment -

          Nope, doh.

          Show
          Dan Poltawski added a comment - Nope, doh.
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.4.5 [ 12653 ]
          Fix Version/s 2.4.4 [ 12575 ]
          Dan Poltawski made changes -
          Testing Instructions Prerequsites:
          # You need a Microsoft Account
          # Please add to your skydrive repository, at least:
          ## An image
          ## A video
          ## An audio file
          ## A word document
          ## Any other sort of file
          ## Please spread these files around folders

          # Enable the skydrive repository plugin
          # You will need to configure an API account with microsoft (http://docs.moodle.org/25/en/Skydrive_repository) and configure the api keys
          # Go to my private files
          # Browse the skydrive repository and ensure that you can view all your skydrive files
          # VERFIY: that you can download each type of file
          # VERIFY: that photos and videos show thumbnails of the file
          Hide
          Dan Poltawski added a comment -

          I've just seen this issue in my list, with a lot of votes and not much action!

          I've rebased the plugin on top of 2.6 and included Ruslan's patches for fixing the breadcrumbs, so submitting this for peer review!

          Show
          Dan Poltawski added a comment - I've just seen this issue in my list, with a lot of votes and not much action! I've rebased the plugin on top of 2.6 and included Ruslan's patches for fixing the breadcrumbs, so submitting this for peer review!
          Dan Poltawski made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Dan Poltawski made changes -
          Fix Version/s 2.6 [ 12579 ]
          Fix Version/s 2.4.5 [ 12653 ]
          Dan Poltawski made changes -
          Labels triaged docs_required qa_test_required triaged ui_change
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
          Hide
          Dan Poltawski added a comment -

          Hold on, I must've been in coooko land, I missed the abuse of $SESSION.

          Show
          Dan Poltawski added a comment - Hold on, I must've been in coooko land, I missed the abuse of $SESSION.
          Hide
          Dan Poltawski added a comment -

          Switched that to MUC now and sending for peer review.

          Show
          Dan Poltawski added a comment - Switched that to MUC now and sending for peer review.
          Dan Poltawski made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Hide
          Dan Poltawski added a comment -

          No peer reviewer yet. I'm going to try my luck in integration.

          Show
          Dan Poltawski added a comment - No peer reviewer yet. I'm going to try my luck in integration.
          Dan Poltawski made changes -
          Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Marina Glancy made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator marina
          Hide
          Marina Glancy added a comment -

          Hi Dan,

          I apologize for the big list of review comments. I'm sure it is a great and useful plugin! And the code looks very nice. It's all repositories API fault...

          general comments:

          • don't forget to include plugin in plugin_manager::standard_plugins_list()
          • maybe it is also worth mentioning in repository/upgrade.txt in case somebody is using the same plugin installed from plugins database
          • icon.png is way too big, should be 16x16

          microsoft_skydrive::__construct()

          • according to Sam, cache::make_from_params() is not recommended outside of unittests. Otherwise it's better to create cache definition in db/caches.php, also it will make it possible to configure cache in cache admin panel

          microsoft_skydrive::download_file()

          • I would recommend to add to curl parameters 'timeout' => repository::GETFILE_TIMEOUT - I added it recently to all other repositories, I think there were issues in case of external server or network problems, filemanager hang, draftarea was lost.
          • We need to make sure that in MDL-40642 the new file gets proper permission

          microsoft_skydrive::get_file_list()

          Also, may be useful to add 'manage' link to https://skydrive.live.com/
          example in dropbox: https://github.com/moodle/moodle/blob/master/repository/dropbox/lib.php#L179

          Holding for now, waiting for your reply.

          Show
          Marina Glancy added a comment - Hi Dan, I apologize for the big list of review comments. I'm sure it is a great and useful plugin! And the code looks very nice. It's all repositories API fault... general comments: don't forget to include plugin in plugin_manager::standard_plugins_list() maybe it is also worth mentioning in repository/upgrade.txt in case somebody is using the same plugin installed from plugins database icon.png is way too big, should be 16x16 microsoft_skydrive::__construct() according to Sam, cache::make_from_params() is not recommended outside of unittests. Otherwise it's better to create cache definition in db/caches.php, also it will make it possible to configure cache in cache admin panel microsoft_skydrive::download_file() I would recommend to add to curl parameters 'timeout' => repository::GETFILE_TIMEOUT - I added it recently to all other repositories, I think there were issues in case of external server or network problems, filemanager hang, draftarea was lost. We need to make sure that in MDL-40642 the new file gets proper permission microsoft_skydrive::get_file_list() for photo/video files it's better to set usual thumbnail (icon of file extension) and set ['realthumbnail' => $file->picture] for lazy loading (see http://docs.moodle.org/dev/Repository_plugins#get_listing.28.24path.3D.22.22.2C_.24page.3D.22.22.29 ) the list of properties miss icon, realicon, license, author, image_height, image_width. Of course if they are known, see the same link. Icon appears if the table or tree layout used in filepicker (instead of thumbnail). Also, may be useful to add 'manage' link to https://skydrive.live.com/ ‎ example in dropbox: https://github.com/moodle/moodle/blob/master/repository/dropbox/lib.php#L179 Holding for now, waiting for your reply.
          Hide
          Dan Poltawski added a comment -

          Hi Marina,

          Thanks a lot for your detailed review!

          don't forget to include plugin in plugin_manager::standard_plugins_list()

          oops. Done https://github.com/danpoltawski/moodle/commit/562525dcc9ee6f58ee60615b1652e02122ef167b

          maybe it is also worth mentioning in repository/upgrade.txt in case somebody is using the same plugin installed from plugins database

          I don't agree - upgrade.txt is for developers and its not relevant for them. Of course it will be in the release notes though.

          icon.png is way too big, should be 16x16

          Doh. Fixed and also squashed so the big one isn't wasting space in the repo.

          according to Sam, cache::make_from_params() is not recommended outside of unittests. Otherwise it's better to create cache definition in db/caches.php, also it will make it possible to configure cache in cache admin panel

          My bad. Fred mentioned this to me and I forgot to reopen this issue to fix it. I have fixed it now though. https://github.com/danpoltawski/moodle/commit/c893448b17538fede72280f1139f6e2eb22ff692

          Although I think i've got misconceptions here, because I am sure, talking to Sam that we thought that making non-defined caches was worthwhile for things which are not worth bothering admins to configure. I mean I don't think its scalable for all the possible caches across the codebase to appear in this admin interface.

          I would recommend to add to curl parameters 'timeout' => repository::GETFILE_TIMEOUT - I added it recently to all other repositories, I think there were issues in case of external server or network problems, filemanager hang, draftarea was lost.

          I haven't done this, can we do this in a new issue (because I noticed that google for example isn't respecting this), so could fix both at once.

          We need to make sure that in MDL-40642 the new file gets proper permission

          I have commented in that issue. I don't agree that we should be doing it in every file_put_contents!

          microsoft_skydrive::get_file_list()

          Thanks - I have improved the metadata - I hadn't seen some of those before!
          https://github.com/danpoltawski/moodle/commit/f6ef724650f063497fbe602c09868fd39c91bf96

          Show
          Dan Poltawski added a comment - Hi Marina, Thanks a lot for your detailed review! don't forget to include plugin in plugin_manager::standard_plugins_list() oops. Done https://github.com/danpoltawski/moodle/commit/562525dcc9ee6f58ee60615b1652e02122ef167b maybe it is also worth mentioning in repository/upgrade.txt in case somebody is using the same plugin installed from plugins database I don't agree - upgrade.txt is for developers and its not relevant for them. Of course it will be in the release notes though. icon.png is way too big, should be 16x16 Doh. Fixed and also squashed so the big one isn't wasting space in the repo. according to Sam, cache::make_from_params() is not recommended outside of unittests. Otherwise it's better to create cache definition in db/caches.php, also it will make it possible to configure cache in cache admin panel My bad. Fred mentioned this to me and I forgot to reopen this issue to fix it. I have fixed it now though. https://github.com/danpoltawski/moodle/commit/c893448b17538fede72280f1139f6e2eb22ff692 Although I think i've got misconceptions here, because I am sure, talking to Sam that we thought that making non-defined caches was worthwhile for things which are not worth bothering admins to configure. I mean I don't think its scalable for all the possible caches across the codebase to appear in this admin interface. I would recommend to add to curl parameters 'timeout' => repository::GETFILE_TIMEOUT - I added it recently to all other repositories, I think there were issues in case of external server or network problems, filemanager hang, draftarea was lost. I haven't done this, can we do this in a new issue (because I noticed that google for example isn't respecting this), so could fix both at once. We need to make sure that in MDL-40642 the new file gets proper permission I have commented in that issue. I don't agree that we should be doing it in every file_put_contents! microsoft_skydrive::get_file_list() Thanks - I have improved the metadata - I hadn't seen some of those before! https://github.com/danpoltawski/moodle/commit/f6ef724650f063497fbe602c09868fd39c91bf96
          Hide
          Marina Glancy added a comment -

          Thanks everybody. Integrated into master.

          Show
          Marina Glancy added a comment - Thanks everybody. Integrated into master.
          Marina Glancy made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          David Monllaó made changes -
          Tester fred
          Frédéric Massart made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Frédéric Massart added a comment - - edited

          Hi Dan,

          The test passes, but before I click the button you might want to filter() the result provided by get_listing(). This ensures that only the files matching the accepted file types are displayed.

          To replicate:

          • Open any TinyMCE
          • Pick an image from Skydrive
          • Make sure only images are displayed

          https://github.com/danpoltawski/moodle/blob/MDL-30740-master/repository/lib.php#L2202

          Show
          Frédéric Massart added a comment - - edited Hi Dan, The test passes, but before I click the button you might want to filter() the result provided by get_listing(). This ensures that only the files matching the accepted file types are displayed. To replicate: Open any TinyMCE Pick an image from Skydrive Make sure only images are displayed https://github.com/danpoltawski/moodle/blob/MDL-30740-master/repository/lib.php#L2202
          Hide
          Marina Glancy added a comment -

          great catch Fred!

          Show
          Marina Glancy added a comment - great catch Fred!
          Hide
          Dan Poltawski added a comment -

          Please fail the issue!

          Show
          Dan Poltawski added a comment - Please fail the issue!
          Dan Poltawski made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Hide
          Marina Glancy added a comment -

          this is how dropbox calls it, it also makes sure that folders are displayed above files:
          https://github.com/moodle/moodle/blob/master/repository/dropbox/lib.php#L261

          Show
          Marina Glancy added a comment - this is how dropbox calls it, it also makes sure that folders are displayed above files: https://github.com/moodle/moodle/blob/master/repository/dropbox/lib.php#L261
          Hide
          Dan Poltawski added a comment -

          Ah lol, I misread sorry, I thought we were talking about output filtering. Maybe not quite as a certain a failure.

          Show
          Dan Poltawski added a comment - Ah lol, I misread sorry, I thought we were talking about output filtering. Maybe not quite as a certain a failure.
          Hide
          Dan Poltawski added a comment - - edited

          OK i've fixed this using the filter function. I had hoped to use the filter function of the Microsoft API:

          http://msdn.microsoft.com/en-us/library/live/hh826531.aspx#reading_folders

          But that didn't seem to do the trick and the accepted_param situation is a pain.

          Of course I had to change the repository API to do this:
          https://github.com/danpoltawski/moodle/commit/b33dcea5a645a4d8fe9833a61bb6e6bd57a622f9

          And I also fixed the loose inclusion Fred mentioned to me:
          https://github.com/danpoltawski/moodle/commit/143344e2797d1d92688c5da7f7109d0a24dcd5f6

          Show
          Dan Poltawski added a comment - - edited OK i've fixed this using the filter function. I had hoped to use the filter function of the Microsoft API: http://msdn.microsoft.com/en-us/library/live/hh826531.aspx#reading_folders But that didn't seem to do the trick and the accepted_param situation is a pain. Of course I had to change the repository API to do this: https://github.com/danpoltawski/moodle/commit/b33dcea5a645a4d8fe9833a61bb6e6bd57a622f9 And I also fixed the loose inclusion Fred mentioned to me: https://github.com/danpoltawski/moodle/commit/143344e2797d1d92688c5da7f7109d0a24dcd5f6
          Hide
          Damyon Wiese added a comment -

          Will add this fix in a second - but i created a bug about it:

          https://tracker.moodle.org/browse/MDL-40708

          Show
          Damyon Wiese added a comment - Will add this fix in a second - but i created a bug about it: https://tracker.moodle.org/browse/MDL-40708
          Hide
          Dan Poltawski added a comment -

          We didn't send that commit. Speaking to fred about it he made me realise its completely stupid for me to change the API because I don't need to do it in the microsoft live api!!

          But also we should probably consider a wider solution.

          Show
          Dan Poltawski added a comment - We didn't send that commit. Speaking to fred about it he made me realise its completely stupid for me to change the API because I don't need to do it in the microsoft live api!! But also we should probably consider a wider solution.
          Dan Poltawski made changes -
          Status Problem during testing [ 10007 ] Waiting for testing [ 10005 ]
          Dan Poltawski made changes -
          Link This issue testing discovered MDL-40709 [ MDL-40709 ]
          Hide
          Dan Poltawski added a comment -

          After a bit of confusion, i've created the follow on issue in MDL-40709 for the accepted_types handling. Fred, are you happy to pass this?

          Show
          Dan Poltawski added a comment - After a bit of confusion, i've created the follow on issue in MDL-40709 for the accepted_types handling. Fred, are you happy to pass this?
          Frédéric Massart made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Frédéric Massart added a comment -

          Passing

          Show
          Frédéric Massart added a comment - Passing
          Frédéric Massart made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Damyon Wiese added a comment -

          Moodle has many old functions,
          And although they cause no malfunction,
          There comes a day,
          When they get deprecated away,
          And get and put on the list for expulsion.

          Thanks for all the reports/testing/fixes this week. This issue has been sent upstream.

          Show
          Damyon Wiese added a comment - Moodle has many old functions, And although they cause no malfunction, There comes a day, When they get deprecated away, And get and put on the list for expulsion. Thanks for all the reports/testing/fixes this week. This issue has been sent upstream.
          Damyon Wiese made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 19/Jul/13
          Mary Cooch made changes -
          Labels docs_required qa_test_required triaged ui_change docs_required triaged ui_change
          Hide
          Mary Cooch added a comment -

          Removing qa_test_required as there is now a test here MDLQA-5736 ready for inclusion in 2.6 testing.

          Show
          Mary Cooch added a comment - Removing qa_test_required as there is now a test here MDLQA-5736 ready for inclusion in 2.6 testing.
          Mary Cooch made changes -
          Labels docs_required triaged ui_change triaged ui_change
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as I have added the existing doc to the repositories list http://docs.moodle.org/26/en/Skydrive_repository

          Show
          Mary Cooch added a comment - Removing docs_required label as I have added the existing doc to the repositories list http://docs.moodle.org/26/en/Skydrive_repository

            People

            • Votes:
              38 Vote for this issue
              Watchers:
              22 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: