Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.6, 2.1.3, 2.2, 2.3
-
Labels:
-
Database:Any
-
Testing Instructions:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-30741_master
-
Rank:33640
Description
The following string value from a quiz question was causing the convert_pre() method in _/lib/html2text.php to get stuck and never finish converting the string to a text representation:
Consider the following function:<br /><pre style="color: rgb(153, 51, 102);">void FillMeUp(char* in_string) {<br /> int i = 0;<br /> while (in_string[i] != '\0') {<br /> in_string[i] = 'X';<br /> i++;<br /> }<br />}</pre>What would happen if a non-terminated string were input to this function?<br /><br />
Activity
The updated code for html2text.php can be found here:
The earliest test.php upload needs to be removed but I do not have permission to do that myself.
I guess this needs to be cherry-picked to all later branches, but that does not seem to be a problem. This looks like a good fix to me, so submitting for integration. +1
Justin, thanks for your report with fix. I've just added you to the developers group in the tracker and am assigning this issue to you as suggested by Tim.
Cherry-picked the commits into all of the remaining 2.x branches and updated the pull and diff information.
Is there anything else that I need to do with this one?
Integrated, thanks!
Hi,
Works as expected.
Tough just noticed this is the out put that I get for first string
The output of the following is "Segmentation Fault", i.e., the program crashes: int main() { int **p = new int*; int *q = new int; *q = 23; *p = q; cout
As you can see the last part after cout (<< **p;
}) is not present, anyway that seems expected behavior to me considering '<' is present.
passing
Thanks
Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!
Now... disconnect, relax and enjoy the next days, yay!
Closing...ciao 
I've incorporated the updated code from the upstream html2text.php file dealing with parsing of PRE tags and written a new unit test in lib/simpletest/testweblib.php for testing the PRE parsing.