Moodle
  1. Moodle
  2. MDL-30743

Consider to drop support for plugin_callback(), moving all uses to the newer component_callback()

    Details

    • Type: Task Task
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.3, 2.8
    • Fix Version/s: DEV backlog
    • Component/s: Libraries
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_28_STABLE

      Description

      After MDL-30592 we have two functions 99.9% equivalent:

      • plugin_callback() the "old" one, with separate $type, $name, $feature, $action, calling always to
      • component_callbackup(), with just component and function

      This issue is about to decide if we want to deprecate the former, moving all uses to the later. Or, alternatively, if both can coexist forever.

      (deprecation would happen in current master - 2.3 -, and drop support in next one - 2.4)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Eloy Lafuente (stronk7) added a comment -

            My +0.5 goes to deprecate (with debugging) and drop the old plugin_callback()

            Show
            Eloy Lafuente (stronk7) added a comment - My +0.5 goes to deprecate (with debugging) and drop the old plugin_callback()
            Hide
            Marina Glancy added a comment -

            We have detected that this issue has been inactive for over two years and also did not collect many votes. It is possible that it has been already implemented in a more recent version of Moodle, or it is not highly demanded. There are unlimited number of ways Moodle functinality can be expanded and improved but we would like to concentrate on the features that will benefit majority of users, and which can not be implemented as plugins. If you have a suggestion for improving Moodle core, and there is no open issue for it in the tracker, please start a new forum discussion to see how many other users agree with you, and then create a new issue providing as many details as possible.

            ==BLK2YIMP20141121==

            Show
            Marina Glancy added a comment - We have detected that this issue has been inactive for over two years and also did not collect many votes. It is possible that it has been already implemented in a more recent version of Moodle, or it is not highly demanded. There are unlimited number of ways Moodle functinality can be expanded and improved but we would like to concentrate on the features that will benefit majority of users, and which can not be implemented as plugins. If you have a suggestion for improving Moodle core, and there is no open issue for it in the tracker, please start a new forum discussion to see how many other users agree with you, and then create a new issue providing as many details as possible. ==BLK2YIMP20141121==
            Hide
            Tim Hunt added a comment -

            Marina Glancy this technical debt still exists, and there are only 15 instances left.

            Someone should finish cleaning this up, and start the process of deprecating plugin_callback. Reopening.

            Show
            Tim Hunt added a comment - Marina Glancy this technical debt still exists, and there are only 15 instances left. Someone should finish cleaning this up, and start the process of deprecating plugin_callback. Reopening.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: