Moodle
  1. Moodle
  2. MDL-30749

notices when exporting answers using question/type/questiontypebase.php code

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      Turn debugging on, and output error messages as part of the page.

      Export a question to XML format using a type which does not override the base export_to_xml method (such as the varnumericset question type found here : https://github.com/jamiepratt/moodle-qtype_varnumericset), ensuring that the feedback blocks are in HTML format.

      Check that there are no php notices in the exported question's file.

      Import the question from the XML file and then edit it. The feedback edit areas should now be HTML editors.

      Show
      Turn debugging on, and output error messages as part of the page. Export a question to XML format using a type which does not override the base export_to_xml method (such as the varnumericset question type found here : https://github.com/jamiepratt/moodle-qtype_varnumericset ), ensuring that the feedback blocks are in HTML format. Check that there are no php notices in the exported question's file. Import the question from the XML file and then edit it. The feedback edit areas should now be HTML editors.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
    • Rank:
      33666

      Description

      There is still a problem with exporting answers using the code in the base class.

      The code mistakenly refers to $question->feedbackformat rather than $answer->feedbackformat at line 1012.

        Activity

        Hide
        Tim Hunt added a comment -

        Thanks Jamie. Submitting for integration.

        Note that you need to use the public git://github.com/jamiepratt/moodle.git github URL, not your private SSH-only one. I fixed it.

        Show
        Tim Hunt added a comment - Thanks Jamie. Submitting for integration. Note that you need to use the public git://github.com/jamiepratt/moodle.git github URL, not your private SSH-only one. I fixed it.
        Hide
        Sam Hemelryk added a comment -

        Thanks Jamie, this has been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Jamie, this has been integrated now.
        Hide
        Sam Hemelryk added a comment -

        Tested during integration and passed.

        Show
        Sam Hemelryk added a comment - Tested during integration and passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

        Now... disconnect, relax and enjoy the next days, yay!

        Closing...ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: