Inconsistent breadcrumb when browsing categories

The behavior was changed in commit c6a3aa720d33b058fbf8d199418cd8d120165b65, especially this change:

diff --git a/lib/navigationlib.php b/lib/navigationlib.php
index 625a516..64aa8c0 100644
--- a/lib/navigationlib.php
+++ b/lib/navigationlib.php
@@ -1060,7 +1060,7 @@ class global_navigation extends navigation_node {
         $mycourses = enrol_get_my_courses(NULL, 'visible DESC,sortorder ASC', $limit);
         $showallcourses = (count($mycourses) == 0 || !empty($CFG->navshowallcourses));
         $showcategories = ($showallcourses && $this->show_categories());
-        $issite = ($this->page->course->id != SITEID);
+        $issite = ($this->page->course->id == SITEID);
         $ismycourse = (array_key_exists($this->page->course->id, $mycourses));
 
         // Check if any courses were returned.

Thanks for reporting that.

I've put that on the backlog.

In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

Hi Tomasz, I've just linked a couple of issues that duplicate this issue.
I have a solution for this issue now and have commented on MDL-31631 to sort out with others who are working on it which issues we will use.
Hopefully there will be a solution in core for this within a week or two.

Cheers
Sam

We are having the same issue on a 2.3 Moodle: Course category managers see no breadcrumbs where all other users see them for the same course category page.

I needed 4 hours but I found where this was failing (for the above problem we were having).

The problem is in line 1201 in lib/navigationlib.php and can get solved that way:

--- a/lib/navigationlib.php
+++ b/lib/navigationlib.php
@@ -1197,7 +1197,7 @@ class global_navigation extends navigation_node {
                 break;
             case CONTEXT_COURSECAT :
                 // This has already been loaded we just need to map the variable
-                if ($showcategories) {
+                if ($this->show_categories()) {
                     $this->load_all_categories($this->page->context->instanceid, true);
                 }
                 break;

I pushed that change to https://github.com/OdyX/moodle/tree/wip-MDL-30754-MOODLE_23_STABLE

Cheers,

OdyX

Thanks OdyX, I've had a look and a test, you change works perfectly and looks spot on. I've created branches for each version this should land to and am putting it up for integration now.

Many thanks
Sam

thanks, thats integrated into master and 23.

Applied the changes and it seems to work in Moodle 2.3.1 (Build: 20120706). Great work.
Many thanks.

Works as described in master and 2.3. Passing.

I've linked a bug I spotted while testing this.

From somewhere within the clouds...

Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

Ciao