Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30764

Turning off Grouping requires editing activity twice

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      0. Enable the 'groupmembersonly' option on the test server (under development/experimental/beware of the leopard/disused filing cabinet/experimental settings, or some similar location). Add a grouping on your test course if you don't already have one.

      1. Create a new Page activity. Fill in all the required fields, then scroll down to the common settings and show advanced if required.
      + Note that the grouping dropdown is correctly greyed out until you turn on 'Group members only'.

      2. Turn on 'Group members only' and select the grouping. Save and display.

      3. Edit page settings. Set the grouping option to 'None' and turn off 'Group members only'. Save and return to course.
      + The grouping should be turned off (not displayed next to the activity name).

      Currently this does not work - it turns off group members only but does not turn off the grouping.

      Show
      0. Enable the 'groupmembersonly' option on the test server (under development/experimental/beware of the leopard/disused filing cabinet/experimental settings, or some similar location). Add a grouping on your test course if you don't already have one. 1. Create a new Page activity. Fill in all the required fields, then scroll down to the common settings and show advanced if required. + Note that the grouping dropdown is correctly greyed out until you turn on 'Group members only'. 2. Turn on 'Group members only' and select the grouping. Save and display. 3. Edit page settings. Set the grouping option to 'None' and turn off 'Group members only'. Save and return to course. + The grouping should be turned off (not displayed next to the activity name). Currently this does not work - it turns off group members only but does not turn off the grouping.
    • Workaround:
      Hide

      Edit settings twice (once to turn off grouping, then again to turn off groupmembersonly).

      Show
      Edit settings twice (once to turn off grouping, then again to turn off groupmembersonly).
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-30764-master

      Description

      If you decide to turn off both the 'Grouping' and 'Group members only' options on some activity types, the grouping change is not saved because the field gets disabled, so it is not set to 'none'.

      My proposed solution is that the 'disable' logic should only apply when adding a new activity or one which has grouping set to 'None'. If grouping value in database is not none, then the field will not be disabled, regardless of the setting of groupmembersonly.

      NOTE: The same problem also affects ordinary use of groupings if you set group mode to 'None'. I found it first with groupmembersonly, but am fixing for both.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jan/12